OCPBUGS-76318: pkg/helpers: Print the right error object by tchap · Pull Request #2197 · openshift/oc

tchap · 2026-02-06T11:45:48Z

CheckOAuthDisabledErr prints a wrong error object. This is now fixed.

Also improved readability a bit and fixed some typos.

CheckOAuthDisabledErr prints a wrong error object. This is now fixed.

openshift-ci-robot · 2026-02-06T11:45:56Z

@tchap: This pull request references Jira Issue OCPBUGS-76318, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

CheckOAuthDisabledErr prints a wrong error object. This is now fixed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-02-06T11:46:08Z

Walkthrough

The pull request modifies error handling in pkg/helpers/cmd/errors.go, replacing a set-based group membership check with direct pairwise comparison for two known groups, fixing a typographical error in a comment, updating error message formatting to reference the original error variable, and correcting embedded server message grammar.

Changes

Cohort / File(s)	Summary
Error handling logic `pkg/helpers/cmd/errors.go`	Replaces set-based group membership check with direct pairwise comparison for oauthv1/userv1 groups; fixes typographical error ("object iself" → "object itself") in comment; updates error formatting to reference originalError variable instead of local err; corrects embedded OAuth server message grammar and formatting from "Error: … are not enabled" to "%s.%s are not enabled".
Dependency management `go.mod`	Minor version or dependency updates reflecting changes in the main package.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tchap · 2026-02-06T11:46:43Z

/jira refresh

openshift-ci-robot · 2026-02-06T11:46:51Z

@tchap: This pull request references Jira Issue OCPBUGS-76318, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ardaguclu · 2026-02-06T11:52:03Z

pkg/helpers/cmd/errors.go


 Original error:
-%w`, details.Kind, details.Group, err))
+%w`, details.Kind, details.Group, originalError))


ardaguclu · 2026-02-06T11:52:43Z

pkg/helpers/cmd/errors.go

 	}

-	if !sets.New[string](oauthv1.GroupVersion.Group, userv1.GroupVersion.Group).Has(details.Group) {
+	if details.Group != oauthv1.GroupVersion.Group && details.Group != userv1.GroupVersion.Group {


The reason of this change?

It's IMO more readable, but I can change it back 🙂

It works for me. No need to change :)

ardaguclu · 2026-02-06T11:58:14Z

Thank you
/lgtm
/approve

openshift-ci · 2026-02-06T11:58:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tchap · 2026-02-06T12:27:33Z

/verified by @tchap

openshift-ci-robot · 2026-02-06T12:27:48Z

@tchap: This PR has been marked as verified by @tchap.

Details

In response to this:

/verified by @tchap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-02-06T14:50:59Z

/retest-required

Remaining retests: 0 against base HEAD 894e94b and 2 for PR HEAD c9f1f7c in total

tchap · 2026-02-06T17:04:59Z

/retest

openshift-ci · 2026-02-06T20:13:26Z

@tchap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-serial-1of2	`c9f1f7c`	link	true	`/test e2e-aws-ovn-serial-1of2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tchap · 2026-02-08T23:23:53Z

/retest

pkg/helpers: Print the right error object

c9f1f7c

CheckOAuthDisabledErr prints a wrong error object. This is now fixed.

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 6, 2026

openshift-ci bot requested review from ardaguclu, ingvagabund and zhouying7780 February 6, 2026 11:46

ardaguclu reviewed Feb 6, 2026

View reviewed changes

openshift-ci bot assigned ardaguclu Feb 6, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 6, 2026

Conversation

tchap commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

coderabbitai bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

tchap commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

ardaguclu Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

ardaguclu Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

tchap Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

ardaguclu Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

ardaguclu commented Feb 6, 2026

Uh oh!

openshift-ci bot commented Feb 6, 2026

Uh oh!

tchap commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

openshift-ci-robot commented Feb 6, 2026

Uh oh!

tchap commented Feb 6, 2026

Uh oh!

openshift-ci bot commented Feb 6, 2026

Uh oh!

tchap commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tchap commented Feb 6, 2026 •

edited

Loading

coderabbitai bot commented Feb 6, 2026 •

edited

Loading