OCPBUGS-76319: Strip debugging symbols when releasing oc

[tchap]

We don't want the debug RPM package, so I am setting -w -s in oc.spec directly.

For other cases, oc is being built using the included Dockerfiles, so I updated those as well.

go build is now passed -trimpath also so that there are no absolute file paths in the executable.

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-76319, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Makefile, Dockerfiles, and RPM spec updated to embed expanded linker -X metadata flags and to propagate GO_BUILD_EXTRAFLAGS; container and RPM build steps export GO_LD_EXTRAFLAGS (adding -s -w) and GO_BUILD_EXTRAFLAGS (adding -trimpath) before running make.

Changes

Cohort / File(s)	Summary
Makefile build flags & metadata Makefile	Changed GO_LD_EXTRAFLAGS from := to += and added many -X linker flags to embed git/version/build metadata; updated GO_BUILD_FLAGS and platform variants (GO_BUILD_FLAGS_DARWIN, GO_BUILD_FLAGS_WINDOWS, GO_BUILD_FLAGS_LINUX_CROSS) to append $(GO_BUILD_EXTRAFLAGS).
Container build steps (cli artifacts) images/cli-artifacts/Dockerfile.rhel	Sets GO_LD_EXTRAFLAGS (adds -s -w) and GO_BUILD_EXTRAFLAGS (adds -trimpath) in RUN steps for both rhel-8 and rhel-9 builder stages, then runs make cross-build.
Container build steps (cli) images/cli/Dockerfile.rhel	Replaced single RUN with a multi-part RUN that exports GO_BUILD_EXTRAFLAGS (-trimpath) and GO_LD_EXTRAFLAGS (-s -w), runs make build, then gzips oc-tests-ext.
RPM spec build exports oc.spec	Adds export GO_LD_EXTRAFLAGS="${GO_LD_EXTRAFLAGS} -s -w" and export GO_BUILD_EXTRAFLAGS="${GO_BUILD_EXTRAFLAGS} -trimpath" before invoking %{make} build for the RPM build step.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tchap]

/jira refresh

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-76319, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-76319, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

I still need to verify what all needs to be done for this, starting with RPM for now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tchap]

/retitle OCPBUGS-76319: Strip debugging symbols when releasing oc

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-76319, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We don't want the debug RPM package, so I am setting -w -s in oc.spec directly.

For other cases, oc is being built using the included Dockerfiles, so I updated those as well.

go build is now passed -trimpath also so that there are no absolute file paths in the executable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/retest

[openshift-ci]

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.