fix(upload.py): fix upload for local #593
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fixes the
'NoneType' object is not a mappingerror when uploading attachments (images, audio) with the Openlayer Python client against a local Openlayer deployment. Local presigned URLs omit S3 policyfields, but the client still passedNoneinto**fields, causing the error.Changes
presigned_response.fields is Noneis not Nonecheck and convert to{}when missingdict(presigned_response.fields)in try/except for robustnessNonewhen unpackingfieldsfields = fields or {}soNoneis never used in**fieldsContext
For local storage (
OPENLAYER_BASE_URL=http://localhost:8080/v1), the presigned URL API returnsurlandstorageUribut nofields. The client leftfieldsasNone, which led to**fields→**Noneand the'NoneType' object is not a mappingerror during multipart upload.Testing
test_openlayer_multimodel.py)