Added encoding to open file#12
Open
screendriver wants to merge 2 commits intoopenlabs:masterfrom
screendriver:encoding
Open
Added encoding to open file#12screendriver wants to merge 2 commits intoopenlabs:masterfrom screendriver:encoding
screendriver wants to merge 2 commits intoopenlabs:masterfrom
screendriver:encoding
Conversation
added 2 commits
August 4, 2014 17:09
Contributor
Author
|
Hmm it seems that the keyword argument "encoding" is not supported in Python 2.7. Is there a workaround for that? |
Contributor
|
I think what we need is |
|
Successfully tested on Windows 8.1 with Python 3.4 |
Contributor
Author
|
Another solution where you don't have to change anything in your Python code: simple replace "Olá" with "Ola" 😉 |
Contributor
|
@screendriver wouldn't that be ironic given what we are all trying to do is translate between languages :) |
Contributor
Author
|
That's true. But look at @rob19780114 s post. It seems to work with the codec Python module. |
|
@sharoonthomas Actually it's not a problem supplying à, but please set the correct encoding, if you do so. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows machines your package can not be installed via pip, so I added utf-8 encoding: