Allow the user to specify whether they want to use POST or GET for pe…#97
Open
wsalazar-peakactivity wants to merge 3 commits intoopencomponents:masterfrom
Open
Conversation
…rforming the OC request to the registry
matteofigus
requested changes
Mar 25, 2019
Member
matteofigus
left a comment
matteofigus
left a comment
There was a problem hiding this comment.
Thanks for the PR. I think adding a way to force POST is a useful feature, especially in case you have big payloads etc.
-
Can we handle the scenario where there are more than 1 component and
method=GET? I think in that case, we should probably return with an exception or error, as the GET only allows one component. -
Can we add some unit or acceptance tests for the various scenarios (empty|GET|POST|GET+multiple components exception)?
-
Can you update the README for documenting the new
methodparameter?
Thanks!
Collaborator
Author
|
Absolutely. I'll get back to you in a few days with an updated PR. Thanks. |
… is set to GET. Update to README file for httpMethod.
Collaborator
Author
|
This is not ready for review just yet. I meant to push this to my fork but for some reason it got picked up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rforming the OC request to the registry