Convert HTML tables to Markdown tables#1532
Open
StephenBrown2 wants to merge 3 commits intoopenaps:masterfrom
Open
Convert HTML tables to Markdown tables#1532StephenBrown2 wants to merge 3 commits intoopenaps:masterfrom
StephenBrown2 wants to merge 3 commits intoopenaps:masterfrom
Conversation
Using python-markdown syntax via sphinx-markdown-tables extension
StephenBrown2
force-pushed
the
markdown_tables
branch
from
5e4b278 to
eb295c0
Compare
StephenBrown2
force-pushed
the
markdown_tables
branch
from
eb295c0 to
c56a098
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using python-markdown syntax via sphinx-markdown-tables extension.
I noticed that some of the formatting wasn't being applied in the tables, and figured it was probably because of the inline html, markdown processing was being suspended.
This converts all the
<table>s to markdown tables, so that the formatting will work, and also improves the readability and fixes the markup (The bluetooth tethering table was particularly poor markup).HTML tags can still be used in the table cells, as with
<br>s in theOPENAPS_lines in Nightscout setup.While testing this locally, I used the
make servecommand, which errored as there is nobuildcommand, and I also added thebuild/folder to.gitignore.