refactor: Move Sprocket JS files to Webpack (Part 2)#3030
Draft
arkirchner wants to merge 5 commits intomainfrom
Draft
refactor: Move Sprocket JS files to Webpack (Part 2)#3030arkirchner wants to merge 5 commits intomainfrom
arkirchner wants to merge 5 commits intomainfrom
Conversation
arkirchner
force-pushed
the
ak/move_sprocket_assets_to_webpack_part_2
branch
from
077f5f9 to
82a05a6
Compare
arkirchner
commented
Jul 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ak/move_sprocket_assets_to_webpack_part_1 #3030 +/- ##
==========================================================================
Coverage 70.08% 70.08%
==========================================================================
Files 215 215
Lines 6850 6850
==========================================================================
Hits 4801 4801
Misses 2049 2049 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkirchner
force-pushed
the
ak/move_sprocket_assets_to_webpack_part_2
branch
2 times, most recently
from
8d3ef65 to
c4be790
Compare
arkirchner
commented
Jul 22, 2025
| var newMode = 'ace/mode/text' | ||
|
|
||
| $.ajax(this.fileTypeURL + '/' + fileTypeID, { | ||
| $.ajax(this.fileTypeURL() + '/' + fileTypeID, { |
Contributor
Author
There was a problem hiding this comment.
Routes.js needs the page to be rendered before execution. Calling this on execution ensures the page is present.
ibrahimkonuk
left a comment
ibrahimkonuk
left a comment
There was a problem hiding this comment.
Looks good to me, but haven't tested locally
christophblessing
requested changes
Jul 23, 2025
Member
christophblessing
left a comment
christophblessing
left a comment
There was a problem hiding this comment.
What about the failing specs? Your changes seem not functional.
MrSerth
requested changes
Jul 23, 2025
Member
MrSerth
left a comment
MrSerth
left a comment
There was a problem hiding this comment.
On my machine, core aspects of the application are broken, such as the navigation. In addition, errors are given on the console, which reminds me of #2953 (review).
arkirchner
force-pushed
the
ak/move_sprocket_assets_to_webpack_part_2
branch
from
c4be790 to
1062f2d
Compare
arkirchner
commented
Jul 28, 2025
arkirchner
force-pushed
the
ak/move_sprocket_assets_to_webpack_part_2
branch
from
1062f2d to
5518e2b
Compare
3 tasks
JavaScript for RfCs, Flashes and the color mode can be moved without modifications. Relates to #3021
arkirchner
force-pushed
the
ak/move_sprocket_assets_to_webpack_part_1
branch
from
ddb6a43 to
721f80e
Compare
Code editor modules are moved and modularized for later removal from global scope. Relates to #3021
arkirchner
force-pushed
the
ak/move_sprocket_assets_to_webpack_part_2
branch
from
5518e2b to
c60094e
Compare
Base automatically changed from
ak/move_sprocket_assets_to_webpack_part_1
to
main
August 1, 2025 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code editor modules are moved with minimal changes.
The editor is tested in the exercise implimentaion page. Admin exercise page and the RfC page.
Relates to #3021