Stopping callback function firing on page load + allowing callback call function by reference#19
Open
robertlyon777 wants to merge 3 commits intoolance:masterfrom
Open
Stopping callback function firing on page load + allowing callback call function by reference#19robertlyon777 wants to merge 3 commits intoolance:masterfrom
robertlyon777 wants to merge 3 commits intoolance:masterfrom
Conversation
pageload and allowing the hidden checkbox to be found with screenreaders Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
pageload and allowing the hidden checkbox to be found with screenreaders
and one can reference a javascript function with the
on_callback/off_callback options.
Now one can do either
on_callback: function() { },
or
on_callback: 'myfunction',
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
These are a few changes I needed to make for this excellent plugin - hopefully they are useful for the core project
Cheers
Robert