Fix config verification and reload error handling#16
Open
xdissent wants to merge 1 commit intoobserving:masterfrom
Open
Fix config verification and reload error handling#16xdissent wants to merge 1 commit intoobserving:masterfrom
xdissent wants to merge 1 commit intoobserving:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all
this.verify()calls only check the error response, which is alwaysundefined. This PR adds averifiedargument to those calls which indicates whether the config is valid. The verification status is determined by checking only the error status of thehaproxy -ccommand (ignoring stderr errors), since it exits with1if the config is invalid.This PR also ignores stderr errors in
reload(), since there may be warnings and the process will exit with1if it fails to start correctly.