Open
Conversation
mbostock
reviewed
Aug 28, 2024
Member
mbostock
left a comment
There was a problem hiding this comment.
Should we fix this earlier, perhaps by having maybeTypedArrowify always coerce array of BigInt back to Number? Or is it Plot’s responsibility to undo BigInt’s strict coercion wherever BigInt may occur?
Contributor
Author
|
It should definitely be earlier — in my code we coerce the whole channel as many times as there are series. But where? Maybe as high as in the map transform, where we do Line 36 in 0032c11 In that case the mapper should possibly have a that would be passed as the third argument to The alternative is (what you say) to preemptively convert all BigInt independently of where they're used. |
Contributor
Author
|
This is very close to #473 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: it's a bit of a bummer in that we're adding overhead for all Arrays (by making a copy of the channel to a Float64Array). Maybe we could just do it if the first non-nullish value is BigInt?
cc: @juba
closes #2154