Replace python logger with twisted log#15
Open
mahendra wants to merge 1 commit intoobjcode:d873c76efrom
Hidden character warning
The head ref may contain hidden characters: "ce1baef7 "
Open
Conversation
Python logging uses blocking APIs. Hence it must not be used in twisted code. A blocking log message can block the entire twisted event loop. Refer to: http://twistedmatrix.com/documents/10.2.0/core/howto/logging.html#auto3
Collaborator
|
I don't think it's a bad idea to swap in the Twisted logger. That said the Twisted logger also blocks unless you're using the syslog observer. I made an attempt at fixing this in Twisted but got bogged down in the inane review process. If Sean is alright with this direction I'd advocate integrating it. His call though since he's working on the logging refactor. |
Owner
|
Twisted logging looks good, will merge once I get a chance to make some of the new log lines grepable with prefixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python logging uses blocking APIs. Hence it must not be used in twisted code. A blocking log message can block the entire twisted event loop.
Refer to: http://twistedmatrix.com/documents/10.2.0/core/howto/logging.html#auto3
Although there is a twisted observer for this, it is still a blocking API. It is not a good practice to use it. (if somebody configures a db based log, it will block).