You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the patch. In fact, the situation is a bit different. The signature for libvlc_media_new_location changed in the dev version: it was previously (in 2.2 and 3.0) libvlc_media_new_location(libvlc_instance_t *p_instance, const char * psz_mrl ) with a libvlc_instance as first parameter. It was then properly automatically wrapped in the pythonic conversion to a vlc.Instance method. In the dev version the first parameter (libvlc_instance_t) has been removed, which makes it not anymore a default vlc.Instance method. The signature is now libvlc_media_new_location(const char * psz_mrl);
The question is now: should we try to maintain backward compatibility (which required having a vlc.Instance just to instanciate a media), or should we track the API principle of decoupling what can be decoupled.
Alright but you still need to create an Instance before you can do anything useful:
Before it can do anything useful, LibVLC must be initialized.
You can create one (or more) instance(s) of LibVLC in a given process, with libvlc_new() and destroy them with libvlc_release().
So I assume that creating a media via libvlc_media_new_location and trying to play it will result in an error.
Therefore calling it from vlc.Instance is probably the better pythonic approach, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it was added manually but only to the 3.0 file. However, it's mentioned in every definition of
media_new.