Open
Conversation
Member
|
Hello @Katzenkralle thanks for your PR. Can you update the README also pls |
Contributor
Author
|
Sure, is that ok? |
Katzenkralle
force-pushed
the
clean_tests
branch
from
3d904d6 to
d28113d
Compare
Member
|
@Katzenkralle I prefer to stay editor/IDE-agnostic for development and testing, so could we use pyproject.toml instead (for the env + settings file) pls? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the need for the
run_tests.shfile by integrating the starting and stopping of the Vaultwarden container directly into the unit tests.Thus making it easier and faster to work with the tests.