build,deps,tools: prepare to update to OpenSSL 3.5#58098
Closed
richardlau wants to merge 3 commits intomainfrom
Closed
build,deps,tools: prepare to update to OpenSSL 3.5#58098richardlau wants to merge 3 commits intomainfrom
richardlau wants to merge 3 commits intomainfrom
Conversation
This reverts commit dfaded8.
Update `parallel/test-crypto-rsa-dsa` to prepare for updating `deps/openssl` to later versions of OpenSSL which support implicit rejections with `RSA_PKCS1_PADDING`.
Co-Authored-By: Richard Lau <rlau@redhat.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
Member
Author
Hah, I forgot that the revert changes thousands of files. Should I open that separately to aid reviewing this PR? |
Member
Author
oh I have lint failures too so I'll have to update anyway. I'll rework this into two PRs. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for #57795. I'm opening a new PR as I had to revert #57835 to get the arch specific files (which run part of OpenSSL's build) to work.
deps/openssl/configfor the new files in OpenSSL 3.5. I'm not wholly happy with the amount of places that need to be updated to add each newly introduced file but that's a possible later improvement (I'm not that familiar with Perl).Note that this PR doesn't do the actual update -- I'm intending for that to be done via the updater workflow once this lands (otherwise this PR will have far too many changed files to be reviewable).
cc @nodejs/crypto
Running the automation to test: https://github.com/nodejs/node/actions/runs/14779389322/job/41494768590
Which is opening #58097