Conversation
PR-URL: #42712 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to Node.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via db8144b. PR-URL: #42711 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
These events are already documented as events of the `http.ServerResponse` class. Document that they can also be emitted on instances of the `http.ClientRequest` class. PR-URL: #42704 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #41513 Refs: https://coverage.nodejs.org/coverage-74b9baa4265a8f0d/lib/internal/blob.js.html Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #42656 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit introduces an initial version of a CLI-based test runner. PR-URL: #42658 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Taking some time off the project, probably returning later this year. PR-URL: #42750 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #42626 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #42744 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
- `outgoingMessage.writableCorked` was added to Node.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via db8144b. - `outgoingMessage.writableEnded` was added to Node.js v12.9.0 via f9b61d2. - `outgoingMessage.writableFinished` was added to Node.js v12.7.0 via 06d0abe. - `outgoingMessage.writableHighWaterMark`, `outgoingMessage.writableLength`, and `outgoingMessage.writableObjectMode` were added to Node.js v12.9.0 via 16e0011. PR-URL: #42737 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
PR-URL: #42760 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* @rollup/plugin-commonjs@21.1.0 * @rollup/plugin-node-resolve@13.2.1 * rollup@2.70.2 PR-URL: #42759 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42758 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
decrementing an iterator returned by `std::vector::erase` may have undefined behaviour and should not be used. Decrementing `end()` on an empty container is undefined and `.erase()` could leave the container empty. Instead, by calling `vec.erase(it--)` we decrement the valid iterator before the erase operation but after being passed to the erase method. In case of `AsyncHooks::RemoveContext` perform the cleanup of empty contexts upfront using `std::remove_if` because the iteration gets interrupted as soon as the context to be removed has been found. PR-URL: #42749 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42746 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
This commit aims to improve the UX when navigating the docs using links to subsections. Previously the browser would scroll down to the section body, skipping the section heading. Using `scroll-margin-top` CSS property, we can fix this behavior (at least on some browsers). Links to other versions are now updated with the current targeted hash to improve the UX when navigating from docs of one release line to another. I've also removed syntax not parsable by older browsers (arrow functions and array destructuring) since the diff is pretty small and should improve UX on those browsers. PR-URL: #42739 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Fix nits/typos and simplify some sentences. PR-URL: #42733 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #42751 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
These methods are inherited from `http.OutgoingMessage` and they are already documented as methods of the `http.ServerResponse` class. For consistency, document them also as methods of the `http.ClientRequest` class. PR-URL: #42691 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
The heap size limit should be the sum of old generation and young generation size limits, and does not solely depend on the limit of the old generation. PR-URL: #42702 Refs: #35711 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: https://en.wikipedia.org/wiki/Byte#Multiple-byte_units PR-URL: #42587 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This should help projects like https://github.com/mafintosh/why-is-node-running and https://github.com/facebook/jest to detect if Worker instances are keeping the event loop active correctly. Fixes: #42091 Refs: mafintosh/why-is-node-running#59 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42756 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Some core modules can be loaded with or without the `node:` prefix. Using the prefix disambiguates which specifiers refer to core modules. This commit updates the docs to use the prefix everywhere a core module is referenced. PR-URL: #42752 Fixes: #38343 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
According to the logs in #42681 (comment), `make format-cpp` exits with an NZEC. This change intentionally ignores the error code because it is irrelevant. We already check if the formatter produced a diff in the next line. Refs: #42681 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42764 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
removed
meta
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
33 tasks
Collaborator
Collaborator
Member
Author
|
@nodejs/releasers |
Collaborator
Collaborator
aduh95
approved these changes
May 3, 2022
Member
Author
|
Release builds are already done at https://ci-release.nodejs.org/job/iojs+release/8435/ |
BethGriggs
approved these changes
May 3, 2022
targos
added a commit
that referenced
this pull request
May 3, 2022
Notable changes: doc: * add @kuriyosh to collaborators (Yoshiki Kurihara) #42824 lib,src: * (SEMVER-MINOR) implement WebAssembly Web API (Tobias Nießen) #42701 test_runner: * (SEMVER-MINOR) add initial CLI runner (Colin Ihrig) #42658 worker: * (SEMVER-MINOR) add hasRef() to MessagePort (Darshan Sen) #42849 PR-URL: #42943
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
May 3, 2022
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
May 3, 2022
This was referenced May 4, 2022
Member
|
Any idea why the changelog here says npm should be v8.8.0, but node 18.1 seems to ship with v8.3.1? |
Member
? |
Member
|
@richardlau hmm, thanks. I did almost the same - using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2022-05-03, Version 18.1.0 (Current), @targos
Notable Changes
c46e7bbf69] - doc: add @kuriyosh to collaborators (Yoshiki Kurihara) #42824b0f7c4c8f9] - (SEMVER-MINOR) lib,src: implement WebAssembly Web API (Tobias Nießen) #4270178a860ae58] - (SEMVER-MINOR) test_runner: add initial CLI runner (Colin Ihrig) #42658bf9240ae8c] - (SEMVER-MINOR) worker: add hasRef() to MessagePort (Darshan Sen) #42849Commits
4694f5bb96] - async_hooks: avoid decrementing iterator after erase (Gabriel Bota) #42749459546b4f0] - benchmark: fix misc/startup failure (Antoine du Hamel) #427466bd24204ea] - bootstrap: use the isolate snapshot in workers (Joyee Cheung) #4270229c8411f99] - bootstrap: move embedded snapshot to SnapshotBuilder (Joyee Cheung) #427024050b0d64f] - build: enable V8's shared read-only heap (Michaël Zasso) #42809f9994e2029] - build: improve reliability of find_python.cmd script (Luigi Pinca) #428105d15eb1a14] - build: fix format-cpp (Darshan Sen) #427647c973474bf] - build: improve the format-cpp error message (Darshan Sen) #427657681e60829] - crypto: validatethisin all webcrypto methods and getters (Filip Skokan) #428152a4c8263c3] - deps: update undici to 5.1.1 (Michaël Zasso) #429391102922ef9] - deps: upgrade npm to 8.8.0 (npm team) #42886279892987b] - deps: remove linux-ppc64 architecture (Daniel Bevenius) #426164abe9879ae] - deps: remove linux-ppc architecture (Daniel Bevenius) #426168dc71f2266] - deps: remove aix-gcc architecture (Daniel Bevenius) #426166dc1f82384] - deps: remove archs/aix64-gcc (Daniel Bevenius) #42616e8734a4771] - deps: add note about removing asm archs (Daniel Bevenius) #426167fae2c9d6e] - deps: add template for generated headers (Daniel Bevenius) #42616294664e32c] - deps: upgrade npm to 8.7.0 (npm team) #4274460e461c45d] - doc: reword "test directory" (LiviaMedeiros) #42817227a45ba60] - doc: remove legacy-Jtest.py option from BUILDING.md (LiviaMedeiros) #42817e313dc6ed9] - doc: http2.createServeroptionsas optional (Daeyeon Jeong) #428328f2b2280cd] - doc: record March 2022 security release steward (Richard Lau) #42876e15d22c024] - doc: initial version of security-model-strategy.md (Michael Dawson) #42709fe65996790] - doc: clarify guide on testing internal errors (Livia Medeiros) #428132f849a460f] - doc: fix markdown formatting in primordials.md (Tobias Nießen) #42877cd2f5a4fd4] - doc: add primordials guidelines (Antoine du Hamel) #386352d76f72665] - doc: elevate node-clinic diagnostic tier (RafaelGSS) #428029b61ac2617] - doc: update WebAssembly strategy with Wasm Web API (Tobias Nießen) #42836c6c1dc5833] - doc: ordervm.Modulelinker arguments correctly (Simen Bekkhus) #42797c46e7bbf69] - doc: add @kuriyosh to collaborators (Yoshiki Kurihara) #4282459da1339b4] - doc: add maintaining-webassembly.md (Michael Dawson) #42660d9f3f05cab] - doc: fix outdated documentation forfamilyproperty (Antoine du Hamel) #427896fa080cb48] - doc: delete heapdump from diagnostic tooling support tiers (Tony Gorez) #42783c32f76d49e] - doc: fix example in assert.md (Livia Medeiros) #427866225370b2e] - doc: fix version history for Loaders API (Antoine du Hamel) #427783d65a3b13e] - doc: addnode:prefix for all core modules (Antoine du Hamel) #4275246c880b99b] - doc: clarify core modules that can be loaded without a prefix (Antoine du Hamel) #42753025b3e786a] - doc: consolidate use of multiple-byte units (Antoine du Hamel) #42587962d80b7a1] - doc: add documentation for inherited methods (Luigi Pinca) #42691222b3e6674] - doc: close tag in n-api.md (Livia Medeiros) #427514c30936065] - doc: copyedit http.OutgoingMessage documentation (Luigi Pinca) #42733d77c59d0f2] - doc: improve fragment (:target) anchors behavior on HTML version (Antoine du Hamel) #42739c50309cb39] - doc: fixadded:info foroutgoingMessage.writable*(Luigi Pinca) #427376b7c35e807] - doc: delete mdb_v8 from diagnostic tooling support tiers (Tony Gorez) #426262a07a9fc3a] - doc: document the 'close' and 'finish' events (Luigi Pinca) #42704ef5ab8179b] - doc: fixadded:info foroutgoingMessage.{,un}cork()(Luigi Pinca) #42711a6e1e7a5d7] - doc,test: add tests and docs for duplex.fromWeb and duplex.toWeb (Erick Wendel) #42738336242a7c6] - errors,console: refactor to use ES2021 syntax (小菜) #428720e16120d0d] - errors,vm: update error and use cause (Gus Caplan) #42820a0638a23b0] - esm: fix imports from non-file module (Antoine du Hamel) #42881dab15f69e3] - esm: graduate top-level-await to stable (Antoine du Hamel) #4287548bbb73f36] - fs: fix mkdirSync so ENOSPC is correctly reported (Santiago Gimeno) #42811d33cbabd79] - lib: remove experimental warning from FormData (Xuguang Mei) #42807ad8269450a] - lib,src: use Response URL as WebAssembly location (Tobias Nießen) #42842b0f7c4c8f9] - (SEMVER-MINOR) lib,src: implement WebAssembly Web API (Tobias Nießen) #42701fdc65032a7] - meta: update AUTHORS (Node.js GitHub Bot) #4284833ac027fdf] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #4276914893c5984] - meta: update AUTHORS (Node.js GitHub Bot) #427602f38b4812c] - meta: move mmarchini to emeritus (mary marchini) #42750718d11fdb0] - perf_hooks: return different functions in timerify (Himself65) #42854e8083664e1] - src: turn SSL_CTX_new CHECK/segfault into JS exception (Anna Henningsen) #4279937ca1102c4] - src: make --no-node-snapshot a per-process option (Joyee Cheung) #428641976284a92] - src: define fs.constants.S_IWUSR & S_IRUSR for Win (Liviu Ionescu) #42757b7e9dd0278] - src: usenode:prefix in example (Antoine du Hamel) #427941a7af6364d] - src: large page attributing an id on Linux (David CARLIER) #42644494650c09f] - src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc (Darshan Sen) #427668e0e576669] - test: add tests for extracting function name (Kohei Ueno) #42399fbda87d966] - test: simplify test-gc-{http-client,net}-* (Luigi Pinca) #427823c796f8328] - test: fixparallel/test-dgram-udp6-link-local-address(Antoine du Hamel) #42795b85a11c28e] - test: improve lib/internal/test_runner/test.js coverage (MURAKAMI Masahiko) #4274559c07a99fb] - test: check ecdsa psychic signature (Filip Skokan) #428630725064695] - test: fix port in net-perf_hooks (Livia Medeiros) #427617b701442de] - test: skip test that cannot pass under --node-builtin-modules-path (Geoffrey Booth) #4283437364abc58] - test: fix flaky HTTP server tests (Tobias Nießen) #428468476ffb85a] - test: useassert.match()instead ofassert(regex.test())(Antoine du Hamel) #42803d311916f37] - test: fix calculations in test-worker-resource-limits (Joyee Cheung) #42702deb3cf49c7] - test: remove the legacy url parser function (Kohei Ueno) #42656be44b1ffcb] - test: improve test coverage of internal/blob (Yoshiki Kurihara) #4151378a860ae58] - (SEMVER-MINOR) test_runner: add initial CLI runner (Colin Ihrig) #426581e7479d34c] - tools: update lint-md-dependencies (Node.js GitHub Bot) #42932c3c5fe78dc] - tools: bump jsdoccomment from 0.22.1 to 0.29.0 (Rich Trott) #4285797fc00a06e] - tools: update eslint to 8.14.0 (Node.js GitHub Bot) #4284593fd77a16f] - tools: update doc to highlight.js@11.5.1 (Node.js GitHub Bot) #4275847c04813f7] - tools: update lint-md-dependencies (Node.js GitHub Bot) #4275918ae2c39d5] - tools: lint osx shell scripts (Livia Medeiros) #427124af0fbd41e] - v8: export cpu_profiler_metadata_size in getHeapCodeStatistics (theanarkh) #42818a19fb609d8] - v8: export more fields in getHeapStatistics (theanarkh) #427841b5856a2a9] - wasi: remove unecessary null check (Michael Dawson) #42819bf9240ae8c] - (SEMVER-MINOR) worker: add hasRef() to MessagePort (Darshan Sen) #42849c3922afa1c] - worker: add hasRef() to the handle object (Darshan Sen) #42756