stream: allow empty string as first stream of pipeline#38723
Closed
Ayase-252 wants to merge 2 commits intonodejs:masterfrom
Closed
stream: allow empty string as first stream of pipeline#38723Ayase-252 wants to merge 2 commits intonodejs:masterfrom
Ayase-252 wants to merge 2 commits intonodejs:masterfrom
Conversation
BridgeAR
approved these changes
May 18, 2021
aduh95
approved these changes
May 18, 2021
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ayase-252
added
needs-ci
aduh95
added
the
author ready
Collaborator
ronag
approved these changes
May 19, 2021
jasnell
approved these changes
May 19, 2021
lpinca
approved these changes
May 19, 2021
Lxxyx
approved these changes
May 20, 2021
RaisinTen
approved these changes
May 20, 2021
Member
|
Landed in b9ef539 |
jasnell
pushed a commit
that referenced
this pull request
May 20, 2021
Fixes: #38721 PR-URL: #38723 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
Fixes: #38721 PR-URL: #38723 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
Member
|
Depends on #37508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty string
''should be allowed as first stream ofpipelineper doc asIterable.Fixes: #38721