Closed
Conversation
targos
reviewed
Dec 7, 2020
aduh95
reviewed
Dec 7, 2020
jasnell
approved these changes
Dec 8, 2020
aduh95
reviewed
Dec 10, 2020
623895e to
f016a82
Compare
Member
|
Failures in GitHub CI (e.g., test-esm-wasm) seem related? |
Contributor
Author
|
I have no idea why: const { WebAssemblyCompile } = primordials;
WebAssemblyCompile(...);doesn’t work, but: const { WebAssembly } = primordials;
WebAssembly.compile(...);does. |
Contributor
|
FWIW, it |
PoojaDurgad
approved these changes
Dec 17, 2020
Collaborator
Member
|
@ExE-Boss would you like to rebase? Maybe it will work with the current V8 version |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
f016a82 to
5788f16
Compare
Contributor
|
IIUC this is never going to work because of the node/deps/v8/src/flags/flag-definitions.h Line 1533 in 38ef4e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used to handle support for WebAssembly modules and static analysis of named exports from CommonJS modules.
Note that adding WebAssembly types to
/typings/primordials.d.tsdepends on microsoft/TypeScript-DOM-lib-generator#959 in order to avoid addinglib: ["DOM"]totsconfig.json.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes