Conversation
This commit suggests that cast-function-type warnings be ignored
from v8.h. Currently, GCC reports a number of warnings like this:
In file included from ../src/util.h:27,
from ../src/aliased_buffer.h:7,
from ../src/memory_tracker.h:5,
from ../src/base_object.h:27,
from ../src/async_wrap.h:27,
from ../src/req_wrap.h:6,
from ../src/req_wrap-inl.h:6,
from ../src/connect_wrap.h:6,
from ../src/connect_wrap.cc:1:
../deps/v8/include/v8.h: In instantiation of
‘void v8::PersistentBase<T>::SetWeak(
P*,
typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType)
[with
P = node::BaseObject;
T = v8::Object;
typename v8::WeakCallbackInfo<P>::Callback =
void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’:
../src/base_object-inl.h:123:42: required from here
../deps/v8/include/v8.h:10374:16: warning:
cast between incompatible function types from
‘v8::WeakCallbackInfo<node::BaseObject>::Callback’
{aka ‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to
‘Callback’
{aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’}
[-Wcast-function-type]
reinterpret_cast<Callback>(callback), type);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The motivation for doing this that it makes it difficult to spot
other warnings that might be important. Since it is v8 that
performs this cast I was not able to find a way around it.
PR-URL: #31475
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
The setup-node GitHub Action installs problem matchers that happen to match the warning message format of Visual Studio's C/C++ compiler. This is resulting in all of our pull requests being annotated with `Unchanged files with check annotations` which are confusing to new contributors as they are not due to the changes in the pull request. The action is used to run `npx envinfo` to dump some information into the logs before the actual build. All GitHub hosted runners already have a version of Node.js installed (12.x at the time of this commit) which we can use to run `envinfo`. Remove the action to avoid using the problematic problem matcher. PR-URL: #31349 Fixes: #31347 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
The exact context of invocation of _writev API is not well known. Also, the choice between _write and _writev is not well known. Add a description to make it explicit. Fixes: #28408 Refs: #28690 Co-authored-by: Parker Bjur <bjur.parker45@gmail.com> PR-URL: #31356 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
type_JSPromise__JS_PROMISE_TYPE and type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE will be used on llnode to identify Promises in memory and core dumps: nodejs/llnode#272. Add these to our postmortem test so we're aware of any changes to this metadata. PR-URL: #31357 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit updates the uvwasi dependency to version 0.0.4. The most notable change is a refactor of the way paths are resolved. All paths, including symlinks, are now resolved in terms of sandboxed paths instead of leaking host system paths. PR-URL: #31363 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit ports nodejs/uvwasi@676ba9a from CMake to gyp. PR-URL: #31363 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Original commit message:
nodejs/uvwasi@20fd9e2 was
accidentally reverted in
nodejs/uvwasi#73. This commit
relands it.
PR-URL: #31363
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #31360 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #31373 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: #28647 Refs: nodejs/node-gyp#1828 PR-URL: #28717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
- Do not set the fd as a property on the native object. - Use the already-existent `GetFD()` method to pass the fd from C++ to JS. - Cache the fd in JS to avoid repeated accesses to the C++ getter. - Set the fd to `-1` after close, thus reliably making subsequent calls using the `FileHandle` return `EBADF`. Fixes: #31361 PR-URL: #31389 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Ref: nodejs/llnode#330 PR-URL: #31391 Refs: nodejs/llnode#330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Declaring and initializing a `struct text_region` is common to all three implementations of the large pages mapping code. Let's make it unconditional. PR-URL: #31385 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host>
PR-URL: #31393 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This test provides missing coverage for __wasi_path_symlink() and __wasi_path_readlink(). PR-URL: #31403 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Fixes: #28386 Refs: #31292 Refs: nodejs/help#2136 PR-URL: #31395 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
The new key type 'dh' corresponds to EVP_PKEY_DH. PR-URL: #31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: #31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This allows using the generateKeyPair API for DH instead of the old stateful DH APIs. PR-URL: #31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Currently, Node.js has separate (stateful) APIs for DH/ECDH, and no support for ECDH-ES. This commit adds a single stateless function to compute the DH/ECDH/ECDH-ES secret based on two KeyObjects. PR-URL: #31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
test-crypto-keygen and test-crypto-dh-stateless are currently flaky on ARM CI systems due to their slow CPUs. PR-URL: #31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This commit improved the stat test a bit by verifying that S_ISDIR() works properly. It also adds missing coverage for __wasi_path_remove_directory(). PR-URL: #31413 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Change the type of `Buffer::kMaxLength` to size_t because upcoming changes in V8 will allow typed arrays > 2 GB on 64 bits platforms. Not all platforms handle file reads and writes > 2 GB though so keep enforcing the 2 GB typed array limit for I/O operations. Fixes: #31399 Refs: libuv/libuv#1501 PR-URL: #31406 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Refactor for clarity and reusability. Make it more obvious that the list is a FIFO queue. PR-URL: #31386 Refs: openjs-foundation/summit#240 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
There is no real reason to manage a count manually, given that checking whether there are C++ callbacks is a single pointer comparison. This makes it easier to add other kinds of native C++ callbacks that are managed in a similar way. PR-URL: #31386 Refs: openjs-foundation/summit#240 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Add a variant of `SetImmediate()` that can be called from any thread. This allows removing the `AsyncRequest` abstraction and replaces it with a more generic mechanism. PR-URL: #31386 Refs: openjs-foundation/summit#240 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
All the I think all other semver-minor changes are worth listing, though. |
codebytere
force-pushed
the
v13.9.0-proposal
branch
from
d501cc9 to
debb417
Compare
Collaborator
Contributor
codebytere
added a commit
that referenced
this pull request
Feb 18, 2020
Notable changes: * async_hooks: * add executionAsyncResource (Matteo Collina) #30959 * doc: * add ronag to collaborators (Robert Nagy) #31498 * crypto: * add crypto.diffieHellman (Tobias Nießen) #31178 * add DH support to generateKeyPair (Tobias Nießen) #31178 * simplify DH groups (Tobias Nießen) #31178 * add key type 'dh' (Tobias Nießen) #31178 * report: * add support for Workers (Anna Henningsen) #31386 * test: * skip keygen tests on arm systems (Tobias Nießen) #31178 PR-URL: #31837
codebytere
force-pushed
the
v13.9.0-proposal
branch
from
debb417 to
8b3ff92
Compare
Collaborator
Member
Author
|
https://ci.nodejs.org/job/node-test-binary-arm-12+/ seems to be failing - anyone have ideas? failed on a few runs now - latest is here. Looks like: cc @nodejs/build? I don't think this is a blocker but i'd like to confirm. |
Member
Looks like the failure is always on the same host (test-requireio_notthetup_sayanee-debian10-arm64_pi3-1) so let's see if it passes now that I've temporarily marked it offline. |
Collaborator
BethGriggs
requested changes
Feb 18, 2020
codebytere
added a commit
that referenced
this pull request
Feb 18, 2020
Notable changes: * async_hooks: * add executionAsyncResource (Matteo Collina) #30959 * doc: * add ronag to collaborators (Robert Nagy) #31498 * crypto: * add crypto.diffieHellman (Tobias Nießen) #31178 * add DH support to generateKeyPair (Tobias Nießen) #31178 * simplify DH groups (Tobias Nießen) #31178 * add key type 'dh' (Tobias Nießen) #31178 * report: * add support for Workers (Anna Henningsen) #31386 * test: * skip keygen tests on arm systems (Tobias Nießen) #31178 PR-URL: #31837
codebytere
force-pushed
the
v13.9.0-proposal
branch
from
8b3ff92 to
218b764
Compare
Member
Author
|
Given that the only change between this run and the last was a changelog typo fix, I don't think I need to run another full CI, but can if others would prefer. |
Member
|
@codebytere Fwiw, I think it’s still worth listing the other semver-minor commits in the notable changes list (not the I don’t think you’d need a full CI after those either, but these changes might be nice to have before this goes out as a release :) |
Notable changes: * async_hooks * add executionAsyncResource (Matteo Collina) #30959 * crypto * add crypto.diffieHellman (Tobias Nießen) #31178 * add DH support to generateKeyPair (Tobias Nießen) #31178 * simplify DH groups (Tobias Nießen) #31178 * add key type 'dh' (Tobias Nießen) #31178 * test * skip keygen tests on arm systems (Tobias Nießen) #31178 * perf_hooks * add property flags to GCPerformanceEntry (Kirill Fomichev) #29547 * process * report ArrayBuffer memory in `memoryUsage()` (Anna Henningsen) #31550 * readline * make tab size configurable (Ruben Bridgewater) #31318 * report * add support for Workers (Anna Henningsen) #31386 * worker * add ability to take heap snapshot from parent thread (Anna Henningsen) #31569 * added new collaborators * add ronag to collaborators (Robert Nagy) #31498 PR-URL: #31837
codebytere
force-pushed
the
v13.9.0-proposal
branch
from
218b764 to
1f0f58c
Compare
Member
Author
|
Release builds are FTBFS on what looks like a V8 issue: Thoughts on how best to proceed? |
codebytere
added a commit
that referenced
this pull request
Feb 18, 2020
Notable changes: * async_hooks * add executionAsyncResource (Matteo Collina) #30959 * crypto * add crypto.diffieHellman (Tobias Nießen) #31178 * add DH support to generateKeyPair (Tobias Nießen) #31178 * simplify DH groups (Tobias Nießen) #31178 * add key type 'dh' (Tobias Nießen) #31178 * test * skip keygen tests on arm systems (Tobias Nießen) #31178 * perf_hooks * add property flags to GCPerformanceEntry (Kirill Fomichev) #29547 * process * report ArrayBuffer memory in `memoryUsage()` (Anna Henningsen) #31550 * readline * make tab size configurable (Ruben Bridgewater) #31318 * report * add support for Workers (Anna Henningsen) #31386 * worker * add ability to take heap snapshot from parent thread (Anna Henningsen) #31569 * added new collaborators * add ronag to collaborators (Robert Nagy) #31498 PR-URL: #31837
codebytere
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 18, 2020
codebytere
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 18, 2020
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29527/ (running for v13.10.0 sanity check) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2020-02-18, Version 13.9.0 (Current), @codebytere
Notable changes
memoryUsage()(Anna Henningsen) #31550Commits
2db7593838] - assert: align character indicators properly (Ruben Bridgewater) #31429a840e9d639] - async_hooks: ensure event after been emitted on runInAsyncScope (legendecas) #317846be51296e4] - (SEMVER-MINOR) async_hooks: add executionAsyncResource (Matteo Collina) #309592de085fe93] - benchmark: use let instead of var (Daniele Belardi) #31592e37f5100e5] - benchmark: swap var for let in benchmarks (Alex Ramirez) #28958819fb76ba5] - Revert "benchmark: refactor helper into a class" (Anna Henningsen) #317228974fa794c] - Revert "benchmark: addtestandalloptions and improve errors" (Anna Henningsen) #3172230f55cebb6] - Revert "benchmark: remove special test entries" (Anna Henningsen) #317221484f5ab6e] - benchmark: remove special test entries (Ruben Bridgewater) #31396ca343caee3] - benchmark: addtestandalloptions and improve errors (Ruben Bridgewater) #313969f2c742626] - benchmark: refactor helper into a class (Ruben Bridgewater) #31396161db608ae] - benchmark: check for and fix multiple end() (Brian White) #316246fe8eda3ca] - benchmark: clean up config resolution in multiple benchmarks (Denys Otrishko) #31581ebdcafafeb] - benchmark: add MessagePort benchmark (Anna Henningsen) #31568eb3c6e9127] - benchmark: use let and const instead of var (Daniele Belardi) #31518b29badad81] - benchmark: fix getStringWidth() benchmark (Rich Trott) #31476519134ddb0] - buffer: improve from() performance (Brian White) #31615769154de07] - buffer: improve concat() performance (Brian White) #315229d45393e95] - buffer: improve fill(number) performance (Brian White) #3148960a69770f5] - build: add configure option to debug only Node.js part of the binary (Anna Henningsen) #3164410f9abe81d] - build: ignore all the "Debug","Release" folders (ConorDavenport) #3156503eade01d7] - build: enable loading internal modules from disk (Gus Caplan) #31321a2b7006847] - build: build docs in GitHub Actions CI workflow (Richard Lau) #315042e216aebcb] - build: do not use setup-node in build workflows (Richard Lau) #31349825d089763] - crypto: fix performance regression (Robert Nagy) #317423c6545f0b4] - crypto: improve randomBytes() performance (Brian White) #31519f84b34d42c] - crypto: improve errors in DiffieHellmanGroup (Tobias Nießen) #314454591202e66] - crypto: assign and use ERR_CRYPTO_UNKNOWN_CIPHER (Tobias Nießen) #31437bf46c304dd] - (SEMVER-MINOR) crypto: add crypto.diffieHellman (Tobias Nießen) #311780d3e095941] - (SEMVER-MINOR) crypto: add DH support to generateKeyPair (Tobias Nießen) #3117815bd2c9f0c] - (SEMVER-MINOR) crypto: simplify DH groups (Tobias Nießen) #31178572322fddf] - (SEMVER-MINOR) crypto: add key type 'dh' (Tobias Nießen) #311780ac124b6b9] - deps: upgrade npm to 6.13.7 (Michael Perrotte) #31558bf7097c77d] - deps: switch to chromium's zlib implementation (Brian White) #312012eeaa5ce40] - deps: uvwasi: cherry-pick 7b5b6f9 (cjihrig) #31495464f4afa66] - deps: upgrade to libuv 1.34.2 (cjihrig) #314779811ebe0c5] - deps: uvwasi: cherry-pick eea4508 (cjihrig) #314322fe0ed3a2e] - deps: uvwasi: cherry-pick c3bef8e (cjihrig) #3143209566be899] - deps: uvwasi: cherry-pick ea73af5 (cjihrig) #3143204f2799ed2] - deps: update to uvwasi 0.0.5 (cjihrig) #314327c4f1ed030] - deps: uvwasi: cherry-pick 941bedf (cjihrig) #3136300e38a749a] - deps: port uvwasi@676ba9a to gyp (cjihrig) #313635bd3f6c258] - deps,test: update to uvwasi 0.0.4 (cjihrig) #313632cd8461e56] - doc: add glossary.md (gengjiawen) #27517c4613c6b8b] - doc: add prerequisites information for Arch (Ujjwal Sharma) #31669b35f83e69b] - doc: fix typo on fs docs (Juan José Arboleda) #316202ff812ca84] - doc: update contact email for @ryzokuken (Ujjwal Sharma) #316702c83946757] - doc: fix default server timeout description for https (Andrey Pechkurov) #31692b56a21fdad] - doc: add directions to mark a release line as lts (Danielle Adams) #317245ae40cd2b2] - doc: expand C++ README with information about exception handling (Anna Henningsen) #3172094a0ec1b99] - doc: update foundation name in onboarding (Tobias Nießen) #31719fda97fa772] - doc: reword possessive form of Node.js in zlib.md (Rich Trott) #31713eea58cd3d5] - doc: reword possessive form of Node.js in modules.md (Rich Trott) #31713d0238190a1] - doc: reword possessive form of Node.js in repl.md (Rich Trott) #3171355a25b3bbe] - doc: reword section title in addons.md (Rich Trott) #31713ba9fae058a] - doc: revise deepEqual() legacy assertion mode text (Rich Trott) #31704f6d78f959f] - doc: improve strict assertion mode color text (Rich Trott) #3170322cf3e3d4e] - doc: consolidate introductory text (Rich Trott) #316671e2327d9e6] - doc: simplify async_hooks overview (Rich Trott) #3166077ec381ea2] - doc: clarify Worker exit/message event ordering (Anna Henningsen) #316424b0085c7e3] - doc: update TSC name in "Release Process" (Tobias Nießen) #316522e6c737281] - doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder (Joyee Cheung) #31656b61b85ccf9] - doc: add note in BUILDING.md about runningmake distclean(Swagat Konchada) #315422991e7c0e3] - doc: correct getting an ArrayBuffer's length (tsabolov) #31632e27f24987e] - doc: ask more questions in the bug report template (Joyee Cheung) #31611b50a6cc54d] - doc: add example to fs.promises.readdir (Conor ONeill) #315521dbe765b0b] - doc: add AsyncResource + Worker pool example (Anna Henningsen) #31601f40264980e] - doc: fix numbering (Steffen) #315753ba0a22c57] - doc: clarify socket.setNoDelay() explanation (Rusty Conover) #31541faec87b7f1] - doc: list largepage values in --help (cjihrig) #315372638110cce] - doc: clarify require() OS independence (Denys Otrishko) #315717fe9d5ebd4] - doc: add protocol option in http2.connect() (Michael Lumish) #315606626c4de3c] - doc: clarify thatv8.serialize()is not deterministic (Anna Henningsen) #31548cde4b51a92] - doc: update job reference in COLLABORATOR_GUIDE.md (Richard Lau) #315574cac2cccd6] - doc: simultaneous blog and email of sec announce (Sam Roberts) #31483e2b3e4e0e3] - doc: update collaborator guide citgm instructions (Robert Nagy) #3154943186e0046] - doc: change error message testing policy (Tobias Nießen) #31421a52df55b9a] - doc: remove redundant properties from headers (XhmikosR) #3149204d783ae71] - doc: update maintaining-V8.md (kenzo-spaulding) #31503f75fe9ab71] - doc: enable visual code indication in headers (Rich Trott) #314938f25e51e4e] - doc: clean up and streamline vm.md examples (Denys Otrishko) #31474729b96137e] - doc: further fix async iterator example (Robert Nagy) #3136715b24b71ce] - doc: add ronag to collaborators (Robert Nagy) #31498e9462b4d44] - doc: fix code display in header glitch (Rich Trott) #31460b1c745877b] - doc: fix syntax in N-API documentation (Tobias Nießen) #3146667d8967f98] - doc: add explanatory to path.resolve description (Yakov Litvin) #314301099524452] - doc: document process.std*.fd (Harshitha KP) #31395843c5c6f46] - doc: fix several child_process doc typos (cjihrig) #31393d77099856a] - doc: fix a broken link in fs.md (himself65) #313731e08d3c2f1] - doc: correct added version for --abort-on-uncaught-exception (Anna Henningsen) #313606055134db6] - doc: explainhexencoding in Buffer API (Harshitha KP) #31352bd54abe3f7] - doc: explain _writev() API (Harshitha KP) #3135691f5e9b0f7] - doc: document missing properties in child_process (Harshitha KP) #313426874deef28] - doc,assert: rename "mode" to "assertion mode" (Rich Trott) #31635788ea36ce0] - doc,net: reword Unix domain path paragraph in net.md (Rich Trott) #31684e3e40a12b0] - doc,util: revise util.md introductory paragraph (Rich Trott) #31685e46cfaf146] - errors: make use of "cannot" consistent (Tobias Nießen) #31420f6392e9fde] - esm: import.meta.resolve with nodejs: builtins (Guy Bedford) #3103221fc81821f] - fs: set path when mkdir recursive called on file (bcoe) #316078669ecc8a2] - fs: bail on permission error in recursive directory creation (bcoe) #315052c2b3ba39c] - fs: do not emit 'close' twice if emitClose enabled (Robert Nagy) #3138332ac1be372] - fs: unset FileHandle fd after close (Anna Henningsen) #313899ecae58643] - lib: delete dead code in SourceMap (Justin Ridgewell) #315127ecf842429] - lib,src: switch Buffer::kMaxLength to size_t (Ben Noordhuis) #3140615c8d9ead1] - meta: move princejwesley to emeritus (Rich Trott) #31730f5ae510e03] - meta: move vkurchatkin to emeritus (Rich Trott) #31729cd520ddfef] - meta: move calvinmetcalf to emeritus (Rich Trott) #31736832255df89] - meta: fix collaborator list errors in README.md (James M Snell) #31655aa266628ba] - module: drop support for extensionless main entry points in esm (Geoffrey Booth) #31415ca81af7d73] - module: correct docs about when extensionless files are supported (Geoffrey Booth) #314156797656d86] - module: revert esm: empty ext from pkg type/main doesnt affect format #31021 (Geoffrey Booth) #31415ae2141effc] - n-api: free instance data as reference (Gabriel Schulhof) #31638c8215699ab] - n-api: rename 'promise' parameter to 'value' (Tobias Nießen) #315445982726ef9] - net: track state of setNoDelay() and prevent unnecessary system calls (Rusty Conover) #31543e7fea14c7b] - (SEMVER-MINOR) perf_hooks: add property flags to GCPerformanceEntry (Kirill Fomichev) #29547672315651d] - (SEMVER-MINOR) process: report ArrayBuffer memory inmemoryUsage()(Anna Henningsen) #31550cd754337f8] - process: fix two overflow cases in SourceMap VLQ decoding (Justin Ridgewell) #3149098f3028c30] - readline: remove intermediate variable (cjihrig) #31676148dfde1d4] - (SEMVER-MINOR) readline: make tab size configurable (Ruben Bridgewater) #313181bcf2f9423] - report: add support for Workers (Anna Henningsen) #313867c2d33f38f] - src: use hex not decimal in IsArrayIndex (Shelley Vohr) #31758a095ef0d52] - src: keep main-thread Isolate attached to platform during Dispose (Anna Henningsen) #317951dec9d196f] - src: wrap HostPort in ExclusiveAccess (Ben Noordhuis) #31717e23023d685] - src: add ExclusiveAccess class (Ben Noordhuis) #3171754caf76210] - src: allow to reuse env options handling (Denys Otrishko) #317116ad8ca5ecf] - src: do not unnecessarily re-assign uv handle data (Anna Henningsen) #316962837788849] - src: fix compile warnings in node_url.cc (Anna Henningsen) #316891d34ab5e43] - src: modernized unique_ptr construction (Yuhanun Citgez) #316540e44902b85] - src: remove dead code in InternalMakeCallback (Gerhard Stoebich) #31622348c7871b6] - src: remove fixed-size GetHumanReadableProcessName (Ben Noordhuis) #316338964077935] - src: fix OOB reads in process.title getter (Ben Noordhuis) #31633af612bcc21] - src: various minor improvements to node_url (James M Snell) #31651f0ffa4cb80] - src: fix inspectingMessagePortfrominitasync hook (Anna Henningsen) #31600425662e2d6] - src: remove unusedWorker::child\_port\_member (Anna Henningsen) #3159943e2c2e643] - src: change Fill() to use ParseArrayIndex() (ConorDavenport) #3159142b835412d] - src: remove duplicate field env in CryptoJob class (ConorDavenport) #315549fd1e717e6] - src: fix console debug output on Windows (Denys Otrishko) #31580277980d288] - src: use __executable_start for linux hugepages (Ben Noordhuis) #315476d5c3cd7ac] - src: remove preview for heap dump utilities (Anna Henningsen) #31570c167ae0a87] - src: fix minor typo in base_object.h (Daniel Bevenius) #31535f04576ede0] - src: fix debug crash handling null strings (Rusty Conover) #31523ef4d081660] - src: simplify native immediate queue running (Anna Henningsen) #31502bc0c1420f0] - src: define noreturn attribute for windows (Alexander Smarus) #314679e9dbd44fe] - src: reduce code duplication in BootstrapNode (Denys Otrishko) #3146576aad0e5e1] - src: use custom fprintf alike to write errors to stderr (Anna Henningsen) #31446a685827a55] - src: add C++-style sprintf utility (Anna Henningsen) #31446049a1727d4] - src: harden running nativeSetImmediate()s slightly (Anna Henningsen) #31468f56de5a3b4] - src: move MemoryInfo() for worker code to .cc files (Anna Henningsen) #313860cacc1facf] - src: add interrupts to Environments/Workers (Anna Henningsen) #31386f8c45b277f] - src: remove AsyncRequest (Anna Henningsen) #31386600e96ec04] - src: add a threadsafe variant of SetImmediate() (Anna Henningsen) #3138674a7cdbe05] - src: exclude C++ SetImmediate() from count (Anna Henningsen) #3138653e566bc50] - src: better encapsulate native immediate list (Anna Henningsen) #31386b8face28e7] - src: reduce large pages code duplication (Gabriel Schulhof) #3138583dd65a469] - src: fix ignore GCC -Wcast-function-type for older compilers (Denys Otrishko) #3152413c6965703] - src: ignore GCC -Wcast-function-type for v8.h (Daniel Bevenius) #314753dd4089b9a] - (SEMVER-MINOR) src,lib: make ^C print a JS stack trace (legendecas) #292076d0b2267ce] - stream: fix finished w/ 'close' before 'finish' (Robert Nagy) #3153480e75ab389] - stream: add regression test for async iteration completion (Matteo Collina) #31508538582b43d] - Revert "stream: fix async iterator destroyed error propagation" (Matteo Collina) #31508f255053033] - stream: fix finished writable/readable state (Robert Nagy) #315273046648580] - stream: implement throw for async iterator (Robert Nagy) #313165a95fa4aeb] - stream: normalize async iterator stream destroy (Robert Nagy) #3131620d0a0e9a7] - stream: add async iterator support for v1 streams (Robert Nagy) #313160654e6790d] - test: mark test-fs-stat-bigint flaky on FreeBSD (Rich Trott) #317286dbe6bde56] - test: fix flaky parallel/test-repl-history-navigation test (Ruben Bridgewater) #317081dae7dc6bc] - test: improve test-fs-stat-bigint (Rich Trott) #31726fa9b59276d] - test: remove flaky designation for test-fs-stat-bigint (Rich Trott) #30437d36ba2b555] - test: fix flaky test-fs-stat-bigint (Duncan Healy) #304375b3c4b3e7d] - Revert "test: refactor all benchmark tests to use the new test option" (Anna Henningsen) #317222c0f3028c9] - test: add debugging output to test-net-listen-after-destroy-stdin (Rich Trott) #316982224211609] - test: improve assertion message in test-dns-any (Rich Trott) #31697b0e37b7180] - test: fix flaky test-trace-sigint-on-idle (Anna Henningsen) #3164558f17c0e6b] - test: stricter assert color test (Ruben Bridgewater) #3142989dcf733c6] - test: improve logged errors (Ruben Bridgewater) #314254878c7a197] - test: refactor all benchmark tests to use the new test option (Ruben Bridgewater) #313963bcc2da887] - test: fix test-benchmark-http (Rich Trott) #316866139d4ea3b] - test: fix flaky test-inspector-connect-main-thread (Anna Henningsen) #3163713c256d31d] - test: add test-dns-promises-lookupService (Rich Trott) #3164023fefba84c] - test: fix flaky test-http2-stream-destroy-event-order (Anna Henningsen) #31610435b9c977a] - test: abstract common assertions in readline-interface test (Ruben Bridgewater) #31423d2a12d3af8] - test: refactor test-readline-interface.js (Ruben Bridgewater) #314237c3cc94b9f] - test: unset NODE_OPTIONS for cctest (Anna Henningsen) #3159462d0c6029d] - test: simplify test-https-simple.js (Sam Roberts) #3158449be50051c] - test: show child stderr output in largepages test (Ben Noordhuis) #31612c3247fedd9] - test: mark additional tests as flaky on Windows (Anna Henningsen) #316063fdec1c790] - test: fix flaky test-memory-usage (Anna Henningsen) #3160223da559ab2] - test: verify threadId in reports (Dylan Coakley) #315565a12cd636b] - test: remove --experimental-worker flag comment (Harshitha KP) #3156307525c317e] - test: make test-http2-buffersize more correct (Anna Henningsen) #31502c4a2f94a11] - test: cover property n-api null cases (Gabriel Schulhof) #31488f2dc694805] - test: fix test-heapdump-worker (Anna Henningsen) #31494b25ea9b1dc] - test: add tests for main() argument handling (cjihrig) #3142638ea53629b] - test: add wasi test for freopen() (cjihrig) #31432c2792aad44] - test: remove bluebird remnants from test fixture (Rich Trott) #31435583d1d9f55] - test: improve wasi stat test (cjihrig) #31413676b84a803] - (SEMVER-MINOR) test: skip keygen tests on arm systems (Tobias Nießen) #31178099c921f40] - test: add wasi test for symlink() and readlink() (cjihrig) #314036256d0ae92] - test: update postmortem test with v12 constants (Matheus Marchini) #313910bafb5c8c8] - test: export public symbols in addons tests (Ben Noordhuis) #287176833f62e9d] - test: add promises metadata to postmortem test (Matheus Marchini) #3135741524282b5] - test,benchmark: fix test-benchmark-zlib (Rich Trott) #31538c34872e464] - test,dns: add coverage for dns exception (Rich Trott) #3167803aac4e65d] - tls: simplify errors using ThrowCryptoError (Tobias Nießen) #3143695d509e974] - tools: update Markdown linter to be cross-platform (Derek Lewis) #31239328b8a6444] - tools: unify make-v8.sh for ppc64le and s390x (Richard Lau) #3162839c86bbe4c] - tools: replace deprecated iteritems() for items() (Giovanny Andres Gongora Granada (Gioyik)) #31528be55f3ec4f] - tty: do not end in an infinite warning recursion (Ruben Bridgewater) #31429a0c1ceddbc] - util: throw if unreachable TypedArray checking code is reached (Rich Trott) #317377b9d6d08f4] - util: add coverage for util.inspect.colors alias setter (Rich Trott) #317439f9edc2c78] - util: throw if unreachable code is reached (Rich Trott) #317125e1bee817c] - util: fix inspection of typed arrays with unusual length (Ruben Bridgewater) #314583da4d5174c] - util: improve unicode support (Ruben Bridgewater) #31319822f2ac640] - worker: add support for .cjs extension (Antoine du HAMEL) #31662cd99dc7368] - worker: properly handle env and NODE_OPTIONS in workers (Denys Otrishko) #317111592c474da] - worker: resetIsolatestack limit after enteringLocker(Anna Henningsen) #315933e5803f91b] - worker: improve MessagePort performance (Anna Henningsen) #316058d3ffbeb55] - (SEMVER-MINOR) worker: add ability to take heap snapshot from parent thread (Anna Henningsen) #315696fdef457c6] - worker: remove redundant closing of child port (aaccttrr) #315555656ec9f71] - worker: move JoinThread() back into exit callback (Anna Henningsen) #31468