Open
Conversation
indutny
requested changes
Jan 13, 2020
Member
indutny
left a comment
There was a problem hiding this comment.
LGTM in general, but it has to cover bitcode as well! C headers apply both to C and bitcode output.
Contributor
Author
|
Sorry, I do not think that I understand. I should change something in bitcode for fixing tests? |
Member
|
Not in the tests. The order of fields has to be changed in the bitcode generator. |
Contributor
Author
|
Thank you. llparse/src/implementation/js/index.ts Line 47 in 564e5c4 |
Member
|
Well, maybe not in JS, but you got it right! |
Contributor
Author
|
I fixed code for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #35
Decide just drop code, interesting thing.
Fields in struct same, but by some cases errors on tests. Currently do not know llparse too good for say why 🤔
btw, should not i8/i16/i32/i64 be u8/u16/u32/u64?