Skip to content
This repository was archived by the owner on Nov 6, 2022. It is now read-only.

Fix sizeof(http_parser) assert on i386#525

Open
mgorny wants to merge 1 commit intonodejs:mainfrom
mgorny:i386-test-fix
Open

Fix sizeof(http_parser) assert on i386#525
mgorny wants to merge 1 commit intonodejs:mainfrom
mgorny:i386-test-fix

Conversation

@mgorny
Copy link

@mgorny mgorny commented Nov 10, 2020

The struct size is actually 28 bytes because the void* field is 4 bytes
shorter. As the people on the original bug explained, x86 has lower
alignment requirements than other arches, so the struct is not padded.
However, this does not mean you can ignore the void* size difference.

The struct size is actually 28 bytes because the void* field is 4 bytes
shorter.  As the people on the original bug explained, x86 has lower
alignment requirements than other arches, so the struct is not padded.
However, this does not mean you can ignore the void* size difference.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant