This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Open
Conversation
Currently the on_headers_complete callback can return 0 to proceed with the response body, 1 to skip the body, and 2 to skip the body and stop looking for further messages, and this decision on what to do with the body can only be made inside the on_headers_complete callback. This commit adds an ability to alter the parser behaviour later after on_headers_complete pauses the parser and returns 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the on_headers_complete callback can return 0 to proceed
with the response body, 1 to skip the body, and 2 to skip the body
and stop looking for further messages, and this decision on what to do
with the body can only be made inside the on_headers_complete callback.
This PR adds an ability to alter the parser behaviour later
after on_headers_complete pauses the parser and returns 0.
To be honest I'm not very fond of the preprocessor usage or the name http_parser_continue_after_on_headers_complete.