windows: mesure flakiness of failed tests

[aduh95]

I'd like to do that for the other platforms, but I couldn't find what files to change.

Refs: nodejs/node@2e4bcfc

[mhdawson]

LGTM

[mhdawson]

@aduh95 for other platforms I believe they need to be added to the CI jobs themselves. If you don't have access to configure the CI jobs we could possibly give you that or one of the build WG members could get together to add to the key platforms.

[richardlau]

Does this work on earlier release lines? i.e. Node.js 14 and 16? We use the same jobs and scripts to test all supported release lines.

[mhdawson]

ooo, good point

[aduh95]

Indeed it fails: test.py: error: no such option: --measure-flakiness

I guess I need to first backport the changes before we can land this (it's already been backported to v16.x, I've opened nodejs/node#45126 to have it on v14.x as well).

[aduh95]

Now that the backport has landed on v14.x, I think this can now move forward.

[aduh95]

@nodejs/build if someone was available to land and deploy this PR, and also apply the change to the other platforms as explained in #3056 (comment), that'd be appreciated. Or if you want to give me temporary access, and tell me where I can find the files to edit, that can work too.

[targos]

Sorry but I've never deployed anything on Windows hosts and I don't know how to do it. I think Remmina is necessary, but the software cannot run on Mac.

[richardlau]

The Windows CI jobs pull down the *.cmd files under jenkins/scripts/windows/ from the main branch of this repository so deploying is merging this PR (I'll do that now -- if anything goes awry we can revert).

The other platforms are not executing scripts that are under source control so each CI job would need to be edited in the web UI (I can't commit to doing that and being around for a while in case of issues right now).

Sorry but I've never deployed anything on Windows hosts and I don't know how to do it. I think Remmina is necessary, but the software cannot run on Mac.

FWIW Connection to the Windows machines is via RDP, of which Remmina is one such client (and we have an Ansible role to write the configuration for). It should be possible to use any other RDP capable client but you'll need to extract the connection details (IP address, user name, password) out of the inventory and secrets.