Rigolredo basic functionality for MSO2000A#967
Open
OllyFunkster wants to merge 2 commits intongscopeclient:masterfrom
Open
Rigolredo basic functionality for MSO2000A#967OllyFunkster wants to merge 2 commits intongscopeclient:masterfrom
OllyFunkster wants to merge 2 commits intongscopeclient:masterfrom
Conversation
added 2 commits
April 24, 2025 15:02
… list of available sample depths.
|
Hi @OllyFunkster, I missed your work on MSO/DS2000 support here. I am working on Rigol driver overhaul in #1017. Would you test it if I incorporate your changes there? |
Author
|
@diggit yes sure thing! I will take a look next time I'm near the scope in question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No attempt at logic analyser channels yet, but basic support for MSO2/DS2 family added. I think the other families should take the same code paths as before, but that's only verified by me having a bit of a think about it, since I don't have the other models to test against.
Really this is just a first pass to see if you're okay with the approach I'm taking.
I have used '0' to represent the Auto mode for the memory depth control, is there any precedence for other instruments having an Auto mode and displaying it in a meaningful way? I certainly want to have it usable since it means I can set up the 'scope using its knobs and I don't end up fetching more samples than I need.