Update upgrade notes in CONTRIBUTING.md, README.md, values.yaml#602
Update upgrade notes in CONTRIBUTING.md, README.md, values.yaml#602jessebot wants to merge 1 commit intonextcloud:mainfrom
CONTRIBUTING.md, README.md, values.yaml#602Conversation
|
I could improve this PR by also making a note in the values.yaml for the image.tag parameter as mentioned in #103 if you agree that's a good idea? |
provokateurin
left a comment
There was a problem hiding this comment.
Upgrading to the latest minor version before upgrading to the next major version should probably also be documented: https://docs.nextcloud.com/server/latest/admin_manual/maintenance/upgrade.html#approaching-upgrades
This is not only for creating PRs to update the default version but also for the people who deploy the updates.
Yeah that would be nice too, just to prevent people ending up in broken states... |
|
Wait, the docs are confusing, due to grammar:
If it's what you're saying here:
Then shouldn't it be this?:
If I can find the repo I need to change this in, I can go update that grammar 🤷 Happy to document that here as well though :) |
b4b6f22 to
a6e0d90
Compare
CONTRIBUTING.md, README.md, values.yaml
|
Yes that sounds wrong indeed, you can fix it in https://github.com/nextcloud/documentation |
|
PR here :) nextcloud/documentation#12062 |
Signed-off-by: Jesse Hitch <jessebot@linux.com> Signed-off-by: jessebot <jessebot@linux.com>
a6e0d90 to
b1aef0d
Compare
| flavor: apache | ||
| # default is generated by flavor and appVersion | ||
| tag: | ||
| # NOTE: Remember if manually setting this values, when upgrading Nextcloud |
There was a problem hiding this comment.
make helm-docs ready by using
| # NOTE: Remember if manually setting this values, when upgrading Nextcloud | |
| # -- NOTE: Remember if manually setting this values, when upgrading Nextcloud |
Description of the change
Adds a section about upgrades to clarify we should only do one major version at a time.
Benefits
just a little doc change to prevent gotchya :)
Possible drawbacks
open to feedback but I think this is minor enough that it's fine.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.