Adding initial LIBRENMS mappings for netutils by bminnix · Pull Request #732 · networktocode/netutils

bminnix · 2025-11-10T14:40:42Z

Adding a mapping for LibreNMS values to network_driver values for the initial values in use.

Switch to poetry-core

Update banner parsing for EOS

* fixes encrypt type7

* initial pass at type hinting and getting mypy to run * update tasks and ci to do mypy as well * rm unused import * fix contributing end-line number * fix contributing end-line number * Add py.typed file to signify availability of type hints to third parties. * Updates to type hinting. * Add EOS _build_banner type hints. * Address feedback. * Linting. * Remove .idea from commit and ignore in .gitignore. * Remove remnants of merge conflict. * PR feedback. * PR comments. * Ignore pylint errors for abstract-method. * Black. * add examples and better exception messaging Co-authored-by: Leo Kirchner <leo@kirchne.red>

adding codeowner

* prep for 1.2.0 release * Update CHANGELOG.md Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

* Updated lib mapping docs (networktocode#113) * Updated lib mapping docs * Updated per review suggestions * Pinned mistune for m2r2 (networktocode#114) * Switch to poetry-core * Update banner parsing for EOS (networktocode#121) Update banner parsing for EOS * Fixes encrypt type7 (networktocode#122) * fixes encrypt type7 * Document support on duplicate lines (networktocode#128) * Few updates to PR of 125 (networktocode#129) * initial pass at type hinting and getting mypy to run * update tasks and ci to do mypy as well * rm unused import * fix contributing end-line number * fix contributing end-line number * Add py.typed file to signify availability of type hints to third parties. * Updates to type hinting. * Add EOS _build_banner type hints. * Address feedback. * Linting. * Remove .idea from commit and ignore in .gitignore. * Remove remnants of merge conflict. * PR feedback. * PR comments. * Ignore pylint errors for abstract-method. * Black. * add examples and better exception messaging Co-authored-by: Leo Kirchner <leo@kirchne.red> * Adding nxos_ssh to Napalm mapper (networktocode#138) * Update CODEOWNERS (networktocode#134) adding codeowner * prep for 1.2.0 release (networktocode#143) * prep for 1.2.0 release * Update CHANGELOG.md Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> Co-authored-by: Adam Byczkowski <38091261+qduk@users.noreply.github.com> Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Dr. X <xenia.mountrouidou@networktocode.com> Co-authored-by: Leo Kirchner <leo@kirchne.red> Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com> Co-authored-by: Andrew Bates <abates@omeganetserv.com>

* adds utility functions ios * addresses comments * addresses comments * adds tests * addresses comments * addresses comment parametrize tests

…ocode#148) Adds get_oui and flat ci process to pull OUI data into repo (networktocode#148) Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> Co-authored-by: Adam Byczkowski <adam.byczkowski@kochgs.com> Co-authored-by: flat-data <flat-data@users.noreply.github.com> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

Add Napalm Getter feature

* feat: Add parser for Citrix NetScaler * test: ✅ Add compliance tests for NetScaler * docs: 📝 Update docs to add NetScaler parser to list * test: ✅ Add tests for cmdPolicy and ssl features * docs: 📝 Add documentation around parent/child missing in NS parser * docs: 📝 Fix indentation in documentation * revert: Revert indentation * revert: Revert deleted empty line Co-authored-by: Justin Drew <jdrew82@users.noreply.github.com>

* Change how dunder version is created * Ignore mypy on metadata 3.8 issues

Resync main back to develop

* Update OUI mappings manually * Flat: latest data (2022-11-04T19:25:07.118Z) { "date": "2022-11-04T19:25:07.118Z", "files": [ { "name": "netutils/oui_mappings.py", "deltaBytes": 9540, "source": "https://standards-oui.ieee.org" } ] } * Revert workflow file * Fix workflow comment spacing Co-authored-by: Adam Byczkowski <adam.byczkowski@kochgs.com> Co-authored-by: flat-data <flat-data@users.noreply.github.com>

Sync 1.3.0

Skip integration test for tcpping (networktocode#168)

* feat: Adds is_classfull is_classful will check if IP network strings fall within class boundaries. Fixes networktocode#157 * docs: Corrects method description. Co-authored-by: Adam Byczkowski <38091261+qduk@users.noreply.github.com> * style: Corrected formatting * docs: Corrects documentation style * doc: Update documentation based on feedback. Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> * fix: Fixed is_classfull missing from jinja filter list * docs: Added better example of ip_classfull usage * docs: Added ignore for pydocstyle Using escaped quotes in pydocs is, apparently, frowned upon and flagged by pydocstyle D300 and D301. However, in the ip_classfull example, the escaped double quotes are for triple double quotes. Removing the backslashs and making the pydoc a raw string won't work, the backslashes still have to be there. Therefore, we're ignoring D300 and D301 in this case. * docs: Updated auto-generated docs Co-authored-by: Adam Byczkowski <38091261+qduk@users.noreply.github.com> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

* add aruba to config parser * fix config parsing * remove unneeded line * add scrapli lookup mapper * aruba parser updates * add aruba_aoscx lib_mapper * Update netutils/config/parser.py Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> * update test case Co-authored-by: lukebates123 <lucas.bates@hpe.com> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

* Minor updates fix classfull address naming in ip.py * PR#networktocode#173 Fix classful naming * fixing broken tests

Release 1.15.0

…0-to-develop Release 1.15.0 to develop

* initial at running config mapper updates --------- Co-authored-by: itdependsnetworks <ken@celenza.org>

Release 1.15.1

…1-to-develop Release 1.15.1 to develop

{ "date": "2025-10-01T02:32:30.453Z", "files": [ { "name": "netutils/data_files/oui_mappings.py", "deltaBytes": 6850, "source": "https://standards-oui.ieee.org" } ] } Co-authored-by: flat-data <flat-data@users.noreply.github.com>

{ "date": "2025-10-01T02:37:17.366Z", "files": [ { "name": "netutils/data_files/protocol_mappings.py", "deltaBytes": -161, "source": "https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.csv" } ] } Co-authored-by: flat-data <flat-data@users.noreply.github.com>

itdependsnetworks · 2025-11-10T15:10:27Z

netutils/data_files/oui_mappings.py

@@ -1,4 +1,5 @@
 """Dictionary object to store OUI information."""
+


Should not be needed, and will likely get reverted.

The changes to this file are coming from ruff rules. I was just following ruff --fix after I realized there was an issue called out by ruff.

itdependsnetworks · 2025-11-10T15:10:54Z

Can you link source of this information for ease of future findings?

bminnix · 2025-11-10T20:00:23Z

Can you link source of this information for ease of future findings?

I'm not sure the best way to go about doing this since there really isn't a great summarized source, suggestions welcomed.

In the current state this is all coming about as follows:

The "constants.py" file is created with "os_manufacturer_map" and "manufacturer_os_map" (both manually created (by @bile0026) after inspecting the files/contents) with the intent to create those specific mappings. All values from the LibreNMS code/base are in this os/manufacturer mapping.
The non-driver values being added to the LIBRENMS_LIB_MAPPING/REVERSE are ones coming in directly from the devices themselves and being used to map to/from the nautobot network drivers. I believe these device values obtained are all SNMP value based (and how LibreNMS is obtaining device data).
The values in LIB_MAPPER dictionaries are just added after seeing the values that were provided by the devices, and any that throw "Manufacturer mapping not found for OS" get added to the mapping then.

We could go through and try to add a mapping entry for each of the os/manufacturer entries, but there really isn't any great source of info for future findings/requirements.

jeffkala · 2025-12-17T20:12:06Z

Think you'll need to add a bit to the development_script to to make sure proper doc tables are auto generated since this is a new mapping.

netutils/development_scripts.py

Line 37 in b3e13d2

MAPPER = {

… script for documentation.

bminnix · 2026-01-05T16:35:39Z

Think you'll need to add a bit to the development_script to to make sure proper doc tables are auto generated since this is a new mapping.

netutils/development_scripts.py

Line 37 in b3e13d2

MAPPER = {

This is done. I had ran the script but forgot to update it first 😬

itdependsnetworks · 2026-01-15T20:22:36Z

netutils/lib_mapper.py

+# LibreNMS | Normalized
+LIBRENMS_LIB_MAPPER_REVERSE = {
+    "arista_eos": "arista_eos",
+    "iosxe": "cisco_xe",
+    "iosxr": "cisco_xr",
+    "nxos": "cisco_nxos",
+    "junos": "juniper_junos",
+    "procera": "applogic_procera",
+}


Suggested change

# LibreNMS | Normalized

LIBRENMS_LIB_MAPPER_REVERSE = {

"arista_eos": "arista_eos",

"iosxe": "cisco_xe",

"iosxr": "cisco_xr",

"nxos": "cisco_nxos",

"junos": "juniper_junos",

"procera": "applogic_procera",

}

# Normalized | LibreNMS

LIBRENMS_LIB_MAPPER_REVERSE = {

"arista_eos": "arista_eos",

"cisco_xe": "iosxe",

"cisco_nxos": "nxos",

"cisco_xr": "iosxr",

"juniper_junos": "junos",

"applogic_procera": "procera",

}

These are in reverse of what they should be, e.g. juniper_junos is normalized.

The below needs to be flipped as well

itdependsnetworks · 2026-01-15T20:34:23Z

netutils/lib_mapper.py

+    "cisco_nxos": "nxos",
+    "cisco_xr": "iosxr",
+    "juniper_junos": "junos",
+    "applogic_procera": "procera",


Would this have ssh and be in netmiko? If so, let's try and reserve the name there, if not we need to add it to _MAIN_LIB_MAPPER

itdependsnetworks and others added 30 commits June 15, 2022 16:29

Merge pull request networktocode#115 from fabaff/patch-1

693d53a

Switch to poetry-core

Update banner parsing for EOS (networktocode#121)

cba310b

Update banner parsing for EOS

Fixes encrypt type7 (networktocode#122)

e757bfe

* fixes encrypt type7

Document support on duplicate lines (networktocode#128)

32f09d1

Adding nxos_ssh to Napalm mapper (networktocode#138)

4a26bcb

Update CODEOWNERS (networktocode#134)

a4227a5

adding codeowner

prep for 1.2.0 release (networktocode#143)

f93a92f

* prep for 1.2.0 release * Update CHANGELOG.md Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

Adds ios utilities (networktocode#146)

2cb954e

* adds utility functions ios * addresses comments * addresses comments * adds tests * addresses comments * addresses comment parametrize tests

Convert to new style mkdocs (networktocode#152)

558d71a

Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

Update links to render properly on rtd and pypi (networktocode#155)

898ef07

Update testing mock strategy (networktocode#154)

cb45903

Add Napalm Getter feature (networktocode#149)

0ef3d37

Add Napalm Getter feature

Change how dunder version is created (networktocode#159)

097fc20

* Change how dunder version is created * Ignore mypy on metadata 3.8 issues

prep for 1.3.0 release (networktocode#160)

8e22a89

Merge commit '0f30e723ef52f4cce31afa15e777ab488471c6dc' into dev2

f5a5189

Remove legacy docs

21ab747

Merge pull request networktocode#162 from itdependsnetworks/dev2

e58d6ce

Resync main back to develop

Disable tcp_ping test (networktocode#167)

a1147af

Merge pull request networktocode#164 from networktocode/develop

07536fe

Sync 1.3.0

Skip integration test for tcpping (networktocode#168)

ceb12e1

Manual flatbot 2 update (networktocode#170)

0dc5d3a

Merge pull request networktocode#169 from networktocode/develop

c839d51

Skip integration test for tcpping (networktocode#168)

fix classfull address naming (networktocode#173)

c43d253

* Minor updates fix classfull address naming in ip.py * PR#networktocode#173 Fix classful naming * fixing broken tests

jeffkala and others added 13 commits September 5, 2025 10:51

remove local docs static files

a12a5b1

Merge pull request networktocode#697 from networktocode/release-1.15.0

a7e411b

Release 1.15.0

Bump version

e4ede55

Merge pull request networktocode#698 from networktocode/release-1.15.…

483f45c

…0-to-develop Release 1.15.0 to develop

initial at running config mapper updates (networktocode#704)

ac2ef03

* initial at running config mapper updates --------- Co-authored-by: itdependsnetworks <ken@celenza.org>

Release v1.15.1

8c67dcb

Merge pull request networktocode#721 from networktocode/release-1.15.1

215f76b

Release 1.15.1

Bump version

39d8145

Merge pull request networktocode#722 from networktocode/release-1.15.…

63d98e7

…1-to-develop Release 1.15.1 to develop

Fix the GitHub release failures occurring in CI. (networktocode#723)

9df1497

Adding LIBRENMS mappings for netutils

80d6486

bminnix requested review from itdependsnetworks, jeffkala and qduk as code owners November 10, 2025 14:40

Added the librenms mapper dictionaries

e49c92f

itdependsnetworks reviewed Nov 10, 2025

View reviewed changes

Added the librenms mapping info to development_scripts.py and ran the…

f9b292b

… script for documentation.

bminnix force-pushed the blm/librenms_lib_mapping branch from 9869d30 to f9b292b Compare January 5, 2026 15:50

bminnix added 3 commits January 5, 2026 11:01

Updated and added librenms mappings with the development_script.py

663375e

Adding a change file for this addition.

677a21a

Renamed changelog file from .add to .added

33070bb

itdependsnetworks reviewed Jan 15, 2026

View reviewed changes

LoneStar-Swish force-pushed the develop branch from a275d73 to 7db22a5 Compare February 2, 2026 20:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding initial LIBRENMS mappings for netutils#732

Adding initial LIBRENMS mappings for netutils#732
bminnix wants to merge 346 commits intonetworktocode:developfrom
bminnix:blm/librenms_lib_mapping

bminnix commented Nov 10, 2025

Uh oh!

itdependsnetworks Nov 10, 2025

Uh oh!

bminnix Nov 10, 2025

Uh oh!

itdependsnetworks commented Nov 10, 2025

Uh oh!

bminnix commented Nov 10, 2025

Uh oh!

jeffkala commented Dec 17, 2025

Uh oh!

bminnix commented Jan 5, 2026

Uh oh!

itdependsnetworks Jan 15, 2026

Uh oh!

itdependsnetworks Jan 15, 2026

Uh oh!

itdependsnetworks Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		@@ -1,4 +1,5 @@
		"""Dictionary object to store OUI information."""

Conversation

bminnix commented Nov 10, 2025

Uh oh!

itdependsnetworks Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

bminnix Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

itdependsnetworks commented Nov 10, 2025

Uh oh!

bminnix commented Nov 10, 2025

Uh oh!

jeffkala commented Dec 17, 2025

Uh oh!

bminnix commented Jan 5, 2026

Uh oh!

itdependsnetworks Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

itdependsnetworks Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

itdependsnetworks Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants