Open
Conversation
|
neoforged-automation
bot
added
the
needs rebase
Contributor
|
@lynxplay, this pull request has conflicts, please resolve them for this PR to move forward. |
JSTs ignored prefixes are still pushed into the output file sink, which is not needed when the input and output sources are the same. The commit adds a stronger version of ignored prefixes, "hidden" prefixes, which are not processed or pushed to the output sink. This mainly aims to prevent potential write permission issues on read-only files during in-place transformation.
lynxplay
force-pushed
the
feature/hidden-prefixes
branch
from
542f5d5 to
8492caa
Compare
neoforged-automation
bot
removed
the
needs rebase
Contributor
Author
|
Rebased 🫡 |
|
could this get merged soon-ish? i also need this for my project and i’m forced to use a fork that implements it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSTs ignored prefixes are still pushed into the output file sink, which
is not needed when the input and output sources are the same.
The commit adds a stronger version of ignored prefixes, "hidden"
prefixes, which are not processed or pushed to the output sink.
This mainly aims to prevent potential write permission issues on
read-only files during in-place transformation.
Requires: #45