Open
Conversation
DimitriPapadopoulos
force-pushed
the
windows_sockets_2
branch
9 times, most recently
from
2224e03 to
4a8c716
Compare
Author
|
https://docs.microsoft.com/windows/win32/api/winsock2/nf-winsock2-accept SOCKET WSAAPI accept(
[in] SOCKET s,
[out] sockaddr *addr,
[in, out] int *addrlen
);https://docs.microsoft.com/windows/win32/api/winsock/nf-winsock-bind int bind(
[in] SOCKET s,
const sockaddr *addr,
[in] int namelen
);https://docs.microsoft.com/windows/win32/api/winsock2/nf-winsock2-connect int WSAAPI connect(
[in] SOCKET s,
[in] const sockaddr *name,
[in] int namelen
);https://docs.microsoft.com/windows/win32/api/winsock/nf-winsock-getsockname int getsockname(
[in] SOCKET s,
[out] sockaddr *name,
[in, out] int *namelen
);https://docs.microsoft.com/windows/win32/api/winsock/nf-winsock-setsockopt int setsockopt(
[in] SOCKET s,
[in] int level,
[in] int optname,
[in] const char *optval,
[in] int optlen
);https://docs.microsoft.com/windows/win32/api/winsock2/nf-winsock2-wsasocketa SOCKET WSAAPI WSASocketA(
[in] int af,
[in] int type,
[in] int protocol,
[in] LPWSAPROTOCOL_INFOA lpProtocolInfo,
[in] GROUP g,
[in] DWORD dwFlags
);
SOCKET WSAAPI WSASocketW(
[in] int af,
[in] int type,
[in] int protocol,
[in] LPWSAPROTOCOL_INFOW lpProtocolInfo,
[in] GROUP g,
[in] DWORD dwFlags
); |
DimitriPapadopoulos
force-pushed
the
windows_sockets_2
branch
5 times, most recently
from
9fae0da to
2695757
Compare
Author
|
Merged into fork selectable-socketpair/selectable-socketpair: |
DimitriPapadopoulos
force-pushed
the
windows_sockets_2
branch
from
2695757 to
501023d
Compare
* socket() https://docs.microsoft.com/windows/win32/api/winsock2/nf-winsock2-socket#return-value [...] a value of INVALID_SOCKET is returned [...] * setsockopt() https://docs.microsoft.com/windows/win32/api/winsock2/nf-winsock2-setsockopt#return-value [...] a value of SOCKET_ERROR is returned [...] * WSASocket() https://docs.microsoft.com//windows/win32/api/winsock2/nf-winsock2-wsasocketw#return-value [...] a value of INVALID_SOCKET is returned [...] * accept() https://docs.microsoft.com/windows/win32/api/winsock2/nf-winsock2-accept#return-value [...] a value of INVALID_SOCKET is returned [...]
The actual optval argument type is DWORD (boolean) for the SOL_SOCKET socket option SO_REUSEADDR: https://docs.microsoft.com/windows/win32/winsock/sol-socket-socket-options The type of the optlen argument of setsockopt() is "int": https://docs.microsoft.com/windows/win32/api/winsock/nf-winsock-setsockopt#syntax The type of the namelen argument of getsockname() is "int *": https://docs.microsoft.com/windows/win32/api/winsock/nf-winsock-getsockname#syntax After these changes, socklen_t is not used anymore. Therefore we can revert from <w2stcpip.h> to <winsock2.h>.
DimitriPapadopoulos
force-pushed
the
windows_sockets_2
branch
from
501023d to
a4d0b8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the code conforms to the Windows Socket 2 documentation.