Chore: Migrate react-native-render-html with history#13
Chore: Migrate react-native-render-html with history#135ZYSZ3K wants to merge 1371 commits intonative-html:mainfrom
Conversation
RenderHTMLProps interface does not have a `baseStyles` prop it should be `baseFontStyle` instead
BREAKING CHANGE: The `triggerTREInvalidationPropNames` has been discontinued. The idea for this prop originated in the premise that many beginners would disregard the issue of passing literal props triggering many re-renders. But I realized it mostly frustrated expectations of newcomers that this library honors React components contract. So I have finally decided to discard the prop, and instead add a lightweight profiler (in dev mode only, of course), which warns the consumer of re-renders happening in a short period of time. You are now responsible for the invalidation of the TRenderEngine, so make sure you memoize the props if the controlling components is expected to re-render often.
Useful to add padding to the right of markers (list element prefixes).
Useful to compute the collapsed top margin for each member of a `TNode` list.
Useful for rendering individual nodes in isolation, e.g. in the `renderItem` prop of a `FlatList`.
Avoid re-renders of children of interative / dynamic custom renderers.
Keys don't need to be handled deeper in the tree, only when returning arrays of React nodes. This was a legacy of v5, where custom renderers were functions. Now that any custom renderer is wrapped in a `TNodeRenderer` which has its own key, there is no need to use this key in custom renderers.
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.6 to 1.19.9. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.6...v1.19.9) --- updated-dependencies: - dependency-name: urijs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
This makes it possible for library users to use TypeScript module augmentation to extend these types
|
@jsamr we had a conversation with @mironiasty about the migration Let me know what do you think about that |
This comment was marked as resolved.
This comment was marked as resolved.
mironiasty
left a comment
There was a problem hiding this comment.
I hope that all files are migrated correctly 🤞
There was a problem hiding this comment.
(This comment is not specific for this file, but I'd like to leverage the thread feature of such file comments).
I have an ask: could you create a rnrh-migration branch and use it as the base for the migration work? The reason is I'd like that we merge to main only when all CI/CD is working properly again. CI/CD is an integral, critical part, and will require some iterations to work properly. There is a lot of tooling involved in these repos.
There was a problem hiding this comment.
Yes, that's what I intent to do: I don't want to merge to main something that in principle doesn't work
There will be more PRs targeting meant to be merged into this one
There was a problem hiding this comment.
Sounds good then!
Really appreciate the work, BTW. Preserving the Git history is something I did not realize was possible, and definitely is a big win.
|
Hello team! |
Hello, |
fda2c82 to
b0cc2d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 57 57
Lines 1148 1148
Branches 313 313
=======================================
Hits 1140 1140
Misses 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Closing in favour of #14 |
Description
This PR is meant to move the contents of
react-native-render-htmlto this library with no other changesUltimately I decided to move
packages/render-htmlandappsdirectories to the repopackages/render-htmlcontains the core logic ofreact-native-render-htmlappscontains testing applications that may be helpfulI plan to create pull requests based off of this one to actually get it to work
References
Repository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-htmlrepo: https://github.com/meliorence/react-native-render-html