feat: hw2-493 - Reverting custom account fields#182
Open
geovanne-duarte-mx wants to merge 1 commit intomasterfrom
Open
feat: hw2-493 - Reverting custom account fields#182geovanne-duarte-mx wants to merge 1 commit intomasterfrom
geovanne-duarte-mx wants to merge 1 commit intomasterfrom
Conversation
geovanne-duarte-mx
requested review from
RyanJones08,
gerfboy and
mattnichols
as code owners
geovanne-duarte-mx
force-pushed
the
gd/HW2-493
branch
from
ae92fcd to
e90eae1
Compare
Contributor
|
What is this MR about? Also, can we not just leave the description template in the MR. |
ndasari2
reviewed
May 29, 2024
| @XmlElement(name = "posted_on") | ||
| private LocalDate postedOn; | ||
| @XmlElement(name = "running_balance") | ||
| private BigDecimal runningBalance; |
There was a problem hiding this comment.
@geovanne-duarte-mx we should not remove running balance field as it's being used by HW and AFCU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Public API Additions/Changes
Please include a description of any new or modified publicly available classes and/or methods (if applicable).
Downstream Consumer Impact
Please include a description of how downstream consumers will be affected (breaking changes, bug fixes, internal behavior modification, etc.). If this PR introduces breaking changes please list out each of the breaking changes, as well as steps for migrating incompatible code.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: