Added EventMachine support#52
Open
mspanc wants to merge 4 commits intomvidner:masterfrom
mspanc:master
Open
Conversation
|
Works great 👍 |
asppsa
added a commit
to asppsa/ruby-dbus
that referenced
this pull request
Jul 13, 2017
This code was pinched from mvidner#52. The original repo for that PR seems to have been deleted.
Owner
|
@imobachgs I see the-installer is using EventMachine, which I have no experience with. Would it help to add proper EM support? Something like this PR? |
|
Yes, I tried EventMachine because threads were being blocked by the Main loop. Having out-of-the-box support in ruby-dbus would make things easier, I guess. Although I am not an expert in EventMachine though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've added EventMachine loop support so right now it is easier to integrate DBus client/server with any other service that is based on EM.