Add option to hide alt text

[hamza221]

adding the option of showing/hiding alt text from images

[ksidibe]

This is a great addition. This is particularly useful for a multi language app like mine where the alt text display text in languages that are not that of the user.

[hamza221]

@mtibben really sorry for the disturbance, but any idea on when can this get a review 😀, Would really appreciate it, if you can give it a look.

[ChristophWurst]

@mtibben friendly ping. Would you be okay with this change?

[andrewnicols]

Personally I do not agree with the direction of this change, but given it's behind a feature flag I think it's probably fine.

[andrewnicols]

Poor method naming. This does not actually convert images.
I'd suggest the same approach as convertBlockquotes and covnertPrewhere they take the value and actually perform the conversion. This will need to be done immediately after the current preg_replace to ensure b/c.

[nick322]

If you have this problem, you can replace it first while waiting for an updated version:

$content = str_replace('alt=', 'alta=', $content); 
$content = str_replace('href=', 'hrefa=', $content);
$html = new Html2Text($content );
$html->getText();

[hamza221]

If you have this problem, you can replace it first while waiting for an updated version:

$content = str_replace('alt=', 'alta=', $content); 
$content = str_replace('href=', 'hrefa=', $content);
$html = new Html2Text($content );
$html->getText();

we switched to a forked version https://github.com/hamza221/html2text in the meantime, but it would be great to switch back to the original package

[nick322]

@andrewnicols Please review the code. Thanks