Allow request IP candidates to contain ports#174
Open
Nextra wants to merge 1 commit intompolden:masterfrom
Open
Allow request IP candidates to contain ports#174Nextra wants to merge 1 commit intompolden:masterfrom
Nextra wants to merge 1 commit intompolden:masterfrom
Conversation
mpolden
reviewed
Feb 7, 2026
| {"127.0.0.1:9999", "X-Forwarded-For", "1.3.3.7:1337,4.2.4.2:4242", []string{"X-Forwarded-For"}, "1.3.3.7"}, // X-Forwarded-For with multiple entries (commas separator, with port) | ||
| {"127.0.0.1:9999", "X-Forwarded-For", "1.3.3.7:1337, 4.2.4.2:4242", []string{"X-Forwarded-For"}, "1.3.3.7"}, // X-Forwarded-For with multiple entries (space+comma separator, with port) | ||
| {"127.0.0.1:9999?ip=1.2.3.4:1234", "", "", nil, "1.2.3.4"}, // passed in "ip" parameter (with port) | ||
| {"127.0.0.1:9999?ip=1.2.3.4:1234", "X-Forwarded-For", "1.3.3.7:1337,4.2.4.2:4242", []string{"X-Forwarded-For"}, "1.2.3.4"}, // ip parameter wins over X-Forwarded-For with multiple entries (with port) |
Owner
There was a problem hiding this comment.
Thanks! Can you undo all the other changes in the diff and add just the new case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the flow of
ipFromRequestto run allremoteIPcandidates throughnet.SplitPortHost(if applicable) regardless of source, instead of treatinghttp.Request.RemoteAddras the lone special case.The motivation behind this is that Azure Application Gateways add the
X-Forwarded-Forheader as a comma separated list ofIP:portinstead of each entry just containing the IP address (ref), making it unnecessarily difficult to deploy echoip as-is to Azure Web App.