Using WASM instantiateStreaming when using URL in browser#521
Open
lmartorella wants to merge 1 commit intomozilla:masterfrom
Open
Using WASM instantiateStreaming when using URL in browser#521lmartorella wants to merge 1 commit intomozilla:masterfrom
lmartorella wants to merge 1 commit intomozilla:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to leverage the
instantiateStreamingAPI when loading the WASM code, in order to keep the URI link intact, and overcome CSP rules when they will be able to cover the current gap about WASM same-origin policies.https://developer.mozilla.org/en-US/docs/WebAssembly/Reference/JavaScript_interface/instantiateStreaming_static
It seems that the minimum browser version requirements are more or less the same.
I added a check by the way in case polyfills or older browsers are used, to keep the same previous logic.
Thx, L.