Ensure a consistent return value for sourceContentFor#391
Open
andrewnicols wants to merge 1 commit intomozilla:masterfrom
Open
Ensure a consistent return value for sourceContentFor#391andrewnicols wants to merge 1 commit intomozilla:masterfrom
andrewnicols wants to merge 1 commit intomozilla:masterfrom
Conversation
Pull Request Test Coverage Report for Build 553
💛 - Coveralls |
The sourceContentFor function was previously returning null when it should have returned an exception when the source content was not provided.
andrewnicols
force-pushed
the
consistentReturnVal
branch
from
04cf08d to
461dd8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sourceContentFor function was previously returning null when it
should have returned an exception when the source content was not
provided.
This was discovered whilst debugging https://bugzilla.mozilla.org/show_bug.cgi?id=1556903 and this issue masked that bug.