Use in-memory tracking for per-handler maxParallelTasks and forward parallel option#5
Open
Use in-memory tracking for per-handler maxParallelTasks and forward parallel option#5
maxParallelTasks and forward parallel option#5Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements in-memory tracking for per-handler concurrency limits to replace expensive database counting operations. It allows workers to enforce both worker-level and per-handler concurrency limits simultaneously.
Changes:
- Added in-memory tracking via
handlerLimitsandrunningByNamemaps in thepoll()method to efficiently enforce per-handler concurrency without database queries - Extended
registerHandler()to accept an optionaloptionsparameter withmaxParallelTasksto specify per-handler concurrency limits - Modified
startPolling()to forward theparalleloption topoll()for worker-level concurrency control - Updated
execute()to handle both the new object-based handler format and legacy function-based format for backward compatibility
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/taskSchema.js | Core implementation of in-memory concurrency tracking, handler registration changes, and backward-compatible handler resolution |
| test/task.test.js | Added test utilities (waitFor) and comprehensive tests for parallel option forwarding and per-handler concurrency limits |
| README.md | Added documentation explaining the new parallelism features with clear code examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
countDocuments()calls when enforcing per-handler concurrency limits and instead track running counts in memory during polling.startPolling({ parallel })is honored bypoll()so the worker can limit overall parallelism.Description
registerHandlerto accept anoptionsparameter and store handlers as{ handler, maxParallelTasks }somaxParallelTasksis available to the poll loop.startPollingto forward theparalleloption intopoll()viathis._currentPollsopoll()knows worker-level concurrency.poll()with an in-memoryhandlerLimitsmap and arunningByNamemap, and filter out blocked names usingfilter.name = { $nin: blockedNames }beforefindOneAndUpdate, while incrementing/decrementingrunningByNamearound eachexecute()call.execute()to resolve the stored handler entry shape and call the handler function via the resolvedhandlerFn(preserving timeouts and repeat behavior).Testing
test/task.test.jsincluding awaitForhelper and tests for forwardingparalleltostartPolling()and for enforcingmaxParallelTasksper handler.Codex Task