Improve s:resolve to also look in parent directories#48
Open
cwis-public wants to merge 1 commit intomoll:masterfrom
Open
Improve s:resolve to also look in parent directories#48cwis-public wants to merge 1 commit intomoll:masterfrom
cwis-public wants to merge 1 commit intomoll:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I have recently switched one of my Node package to a “monorepo” structure, and noticed “gf” stopped working when trying to open modules contained within the monorepo.
Turned out,
s:resolvewasn't exactly working likerequire(): in Node.JS, if some package isn't found at a point in path, Node will try all the parent folders, one by one:https://nodejs.org/api/modules.html#modules_loading_from_node_modules_folders
This PR changes
s:resolveto mimic how Node.JS works, and also adds a test for this case.Thanks for your hard work!
Cheers,
cwis