Skip to content

Add client info to instrumentation callback#221

Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom
chattermill:md-client-instrumentation
Feb 5, 2026
Merged

Add client info to instrumentation callback#221
koic merged 1 commit intomodelcontextprotocol:mainfrom
chattermill:md-client-instrumentation

Conversation

@duboff
Copy link
Contributor

@duboff duboff commented Jan 28, 2026

Motivation and Context

Adding client information to the instrumentation callback. A follow-up to #218 of sorts. Client info is very helpful for analytics and debugging purposes.

How Has This Been Tested?

Yes, tested with the Chattermill MCP (proprietary).

Breaking Changes

No breaking changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • [ x] I have read the MCP Documentation
  • [x ] My code follows the repository's style guidelines
  • [ x] New and existing tests pass locally
  • [ x] I have added appropriate error handling
  • [ x] I have added or updated documentation as needed

Additional context

@duboff duboff changed the title client_info -> client Add client info to instrumentation callback Feb 1, 2026
@duboff duboff force-pushed the md-client-instrumentation branch from b868c46 to e0b0492 Compare February 1, 2026 15:39
@duboff duboff marked this pull request as ready for review February 1, 2026 15:40
@koic
Copy link
Member

koic commented Feb 2, 2026

Can you add test cases for this change?

@duboff
Copy link
Contributor Author

duboff commented Feb 3, 2026

Not quite sure what happened to the CI. Any chance you can rerun it @koic? I don't seem to have the ability to

@koic
Copy link
Member

koic commented Feb 3, 2026

Can you squash your commits into one?

@duboff duboff force-pushed the md-client-instrumentation branch from fdfcee9 to 0593818 Compare February 3, 2026 19:52
@duboff duboff force-pushed the md-client-instrumentation branch from 0593818 to 3818a28 Compare February 4, 2026 11:29
@duboff duboff force-pushed the md-client-instrumentation branch from 3818a28 to 2d926ab Compare February 4, 2026 14:00
@koic koic merged commit 4a71fa8 into modelcontextprotocol:main Feb 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants