Add client info to instrumentation callback#221
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Feb 5, 2026
Merged
Add client info to instrumentation callback#221koic merged 1 commit intomodelcontextprotocol:mainfrom
koic merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
b868c46 to
e0b0492
Compare
Member
|
Can you add test cases for this change? |
Contributor
Author
|
Not quite sure what happened to the CI. Any chance you can rerun it @koic? I don't seem to have the ability to |
koic
reviewed
Feb 3, 2026
Member
|
Can you squash your commits into one? |
fdfcee9 to
0593818
Compare
koic
reviewed
Feb 4, 2026
koic
reviewed
Feb 4, 2026
0593818 to
3818a28
Compare
3818a28 to
2d926ab
Compare
koic
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adding client information to the instrumentation callback. A follow-up to #218 of sorts. Client info is very helpful for analytics and debugging purposes.
How Has This Been Tested?
Yes, tested with the Chattermill MCP (proprietary).
Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context