fix: handle numeric values in JSON schema processing#286
Open
yashwantbezawada wants to merge 1 commit intomistralai:mainfrom
Open
fix: handle numeric values in JSON schema processing#286yashwantbezawada wants to merge 1 commit intomistralai:mainfrom
yashwantbezawada wants to merge 1 commit intomistralai:mainfrom
Conversation
Resolves mistralai#279 The rec_strict_json_schema function was raising ValueError when encountering numeric values in JSON schemas. This prevented usage of Pydantic models with constrained types like conlist, conset, etc. These constrained types include numeric constraint values (minItems, maxItems, etc.) in their JSON schemas, which are valid JSON schema properties that should be preserved during processing. This change updates the function to treat int and float as valid primitive types alongside str and bool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279
Problem
The
rec_strict_json_schemafunction raises aValueErrorwhen processing Pydantic models with constrained types likeconlist,conset, etc.These constrained types generate JSON schemas with numeric constraint values (e.g.,
minItems: 3,maxItems: 5), which are valid JSON schema properties. However, the function only handled strings, booleans, dicts, lists, and None, causing it to fail on these numeric values.Changes
Updated
rec_strict_json_schemato acceptintandfloatas valid primitive types, similar to how it handlesstrandbool. These values are passed through unchanged during schema processing.Also updated the test suite to verify that numeric values are handled correctly and added a specific test case for
conlistmodels.Testing
Verified with the exact reproduction case from the issue:
This now works without raising a ValueError.