Add documentation for enabling Native Wayland support and troubleshooting XWayland issues#103
Merged
ChristopherHX merged 2 commits intominecraft-linux:mainfrom Dec 3, 2024
Merged
Conversation
Member
|
👍 While I don't agree that SDL3 prefers xwayland over wayland. QT does some weird decision by itself having it's own variable to prefer x over wayland or vice versa. In the flatpak using GLFW this is at least true with the version selected during build |
Contributor
Author
|
I don't think I mentioned that SDL3 is the reason that Xwayland is preferred, but I did mention that if you don't have SDL3, you can't run the client under Wayland natively. If you try to unset DISPLAY on a game launcher without Wayland support, it will refuse to launch and kick you back to the Qt Launcher. |
|
|
||
| Once you have the game launcher built with Wayland support, you will need to | ||
| force the client to run under Wayland, as it will still default to running | ||
| under Xwayland. This is done by unsetting the `DISPLAY` environment variable. |
Member
There was a problem hiding this comment.
This point is about this statement, which implies sdl3 prefers x over wayland if both are available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request helps document the issues that can arise from running the client under XWayland, and how to compile the game launcher with native Wayland support. I feel like the documentation does a much better job than #82 when it comes to this purpose, so merging this request should close that one.
I am aware of the progress being made to try and get both the game launcher and the qt launcher to run under SDL3 by default, but considering how long the pull request has been open and I do not have any idea when this pull request will merge, it's important that we address the issue in the meantime.
Once that pull request does merge, the documentation can be further updated by removing the instructions and streamlining the troubleshooting process.