5 json lib#1
Open
silbermantel wants to merge 6 commits intomillxing:masterfrom
silbermantel:5_json_lib
Open
Conversation
This reverts commit 2ad9133.
remove whitespaces, no functional change
the new POC prints the plugin and model of each module for all patchlets which is getting closer to what the extract script intends to do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while cleaning up your code I noticed it could benefit from using the json library.
the vcvreader.py is nothing more than a quick and dirty implementation of listing patchlets in a vcv file.