Allow to use Jedi language server in system environment or virtual environments#25697
Allow to use Jedi language server in system environment or virtual environments#25697inochisa wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree |
|
One other question, did you have an issue regarding this feature? We link an issue to track status and the issue usually outlines the problem and steps to reproduce for tracking. I can make one if not |
I would like to, for the test, I should take a look to see if there is a good way for it.
That's my fault, I forgot to run prettier. |
In fact, there is no direct issue for this, but I got a reminder when I raise the issue davidhalter/jedi#2084, as there is no way for me to test the change. |
…vironments As this extension uses an internal Jedi LSP, it is hard for the users to change the jedi setting to adapt various requirements. And in some cases, the user require a specific version of the Jedi, which is hard to change as it is embedded. Add a new configuration property to allow the users to use Jedi LSP in their system environment or virtual environments, and auto fallback to the internal version if the external version is not found. Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
inochisa
force-pushed
the
run-venv-jedi
branch
from
cbe8d68 to
db2dd2b
Compare
Any suggestion for the test? I have no idea for this PR as it is very simple. It is just add a new variable and chained to the script. |
|
@eleanorjboyd I also change the key to the |
3 participants
As this extension uses an internal Jedi LSP, it is hard for the users to change the jedi setting to adapt various requirements. And in some cases, the user require a specific version of the Jedi, which is hard to change as it is embedded.
Add a new configuration property to allow the users to use Jedi LSP in their system environment or virtual environments, and auto fallback to the internal version if the external version is not found.
fixes: #25722