Add POETRY_VIRTUALENVS_IN_PROJECT environment variable support #1211
+115
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension ignores
POETRY_VIRTUALENVS_IN_PROJECT, so.venvdirectories in Poetry projects aren't correctly identified as in-project Poetry environments. The PET server already handles this env var, but the extension's own classification logic innativeToPythonEnvdidn't account for it.Changes
src/managers/poetry/poetryUtils.ts: AddedisPoetryVirtualenvsInProject()that checksprocess.env.POETRY_VIRTUALENVS_IN_PROJECTfor"1"or"true"(case-insensitive), mirroring the PET server logic inpet-poetry/src/env_variables.rsnativeToPythonEnv: When the env var is set and the environment has a project association (info.project), skip the global virtualenvs directory check — these are in-project envs, not global onessrc/test/managers/poetry/poetryUtils.unit.test.ts: 9 unit tests covering truthy/falsy values and case sensitivityOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.