-
Notifications
You must be signed in to change notification settings - Fork 37
Implement Python installation via uv #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,239
−13
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bed7d6f
feat: implement Python installation via uv
karthiknadig 1f1127e
tests: add unit tests for uvPythonInstaller
karthiknadig 01a2bb4
Address PR review comments: task listener cleanup, use wrappers, add …
karthiknadig 4424e52
Format: apply linter formatting fixes
karthiknadig 9cd0f9b
Fix lint errors: replace 'as any' with proper type casts
karthiknadig 108c8cd
feat: enhance Python installation prompts and responses via uv
karthiknadig 6a561da
feat: add Python version selection for installation via uv
karthiknadig b43e0ae
feat: enhance getUvPythonPath to list only installed uv-managed Pytho…
karthiknadig 40e819f
fix: address PR review comments
karthiknadig ddac04d
formatting
karthiknadig e79c752
fix: add uvNotOnPath to telemetry stage type
karthiknadig 083a1da
Address PR review comments: modal prompt, memoize computeId, update g…
karthiknadig 76aca52
Add unit tests for getUvPythonPath and getAvailablePythonVersions
karthiknadig b0c556f
Merge branch 'main' into bold-unicorn
karthiknadig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| import { Task, TaskExecution, tasks } from 'vscode'; | ||
| import { Disposable, Task, TaskExecution, TaskProcessEndEvent, tasks } from 'vscode'; | ||
|
|
||
| export async function executeTask(task: Task): Promise<TaskExecution> { | ||
| return tasks.executeTask(task); | ||
| } | ||
|
|
||
| export function onDidEndTaskProcess( | ||
| listener: (e: TaskProcessEndEvent) => unknown, | ||
| thisArgs?: unknown, | ||
| disposables?: Disposable[], | ||
| ): Disposable { | ||
| return tasks.onDidEndTaskProcess(listener, thisArgs, disposables); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.