Update eslint from 8 to 9. by sean-mcmanus · Pull Request #14157 · microsoft/vscode-cpptools

sean-mcmanus · 2026-02-02T22:02:41Z

This was mostly done by Copilot Agent mode...well, the initial edit...I had to fix a bunch of stuff it did.

Extension/.scripts/clean.ts

Extension/.scripts/common.ts

sean-mcmanus · 2026-02-03T20:43:57Z

@bobbrow Were all your concerns addressed?

bobbrow · 2026-02-03T23:23:02Z

@bobbrow Were all your concerns addressed?

I haven't had the time to go through very many files yet.

Extension/src/LanguageServer/client.ts

Extension/eslint.config.js

Copilot

Pull request overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Extension/.scripts/common.ts

Extension/src/LanguageServer/client.ts

Extension/src/LanguageServer/extension.ts

Extension/eslint.config.js

Extension/src/LanguageServer/cppBuildTaskProvider.ts

bobbrow

I left one optional comment

Extension/src/LanguageServer/clientCollection.ts

Extension/src/LanguageServer/protocolFilter.ts

Update eslint from 8 to 9.

290f48d

sean-mcmanus requested a review from a team as a code owner February 2, 2026 22:02

github-project-automation bot added this to cpptools Feb 2, 2026

github-project-automation bot moved this to Pull Request in cpptools Feb 2, 2026

sean-mcmanus requested a review from Copilot February 2, 2026 22:03

This comment was marked as resolved.

Sign in to view

Update.

edde02e

sean-mcmanus marked this pull request as draft February 2, 2026 22:10

This comment was marked as resolved.

Sign in to view

sean-mcmanus added 3 commits February 2, 2026 14:26

Re-enable no-unused-variables. Fix fast-glob dependency.

a6bebcc

Add back @typescript-eslint/no-unnecessary-boolean-literal-compare.

eae5b38

Format.

bcc6fc6

sean-mcmanus requested a review from Copilot February 2, 2026 22:58

sean-mcmanus marked this pull request as ready for review February 2, 2026 22:59

This comment was marked as resolved.

Sign in to view

sean-mcmanus requested a review from Copilot February 2, 2026 23:08

This comment was marked as resolved.

Sign in to view

bobbrow reviewed Feb 2, 2026

View reviewed changes

Extension/.scripts/clean.ts Show resolved Hide resolved

bobbrow reviewed Feb 2, 2026

View reviewed changes

Extension/.scripts/clean.ts Outdated Show resolved Hide resolved

bobbrow reviewed Feb 2, 2026

View reviewed changes

Extension/.scripts/common.ts Show resolved Hide resolved

bobbrow reviewed Feb 2, 2026

View reviewed changes

Extension/.scripts/common.ts Show resolved Hide resolved

sean-mcmanus added 2 commits February 2, 2026 16:15

Code review changes.

d3d9e1c

Remove | undefined.

a6c7038

sean-mcmanus requested a review from Colengms February 3, 2026 00:20

This comment was marked as resolved.

Sign in to view

sean-mcmanus added 5 commits February 2, 2026 17:39

Fix build.

99547ab

Try a build fix.

e0ec1a9

Attempt to get the assert failure.

54406fe

Attempt a fix.

b18526f

Fix build error.

12d3a57

More reverting.

636270a

Colengms previously approved these changes Feb 3, 2026

View reviewed changes

Merge branch 'main' into seanmcm/updateEslint

b4c5f74

bobbrow reviewed Feb 3, 2026

View reviewed changes

Extension/src/LanguageServer/client.ts Outdated Show resolved Hide resolved

bobbrow reviewed Feb 3, 2026

View reviewed changes

Extension/eslint.config.js Show resolved Hide resolved

Fixes.

8f33c29

sean-mcmanus dismissed Colengms’s stale review via 8f33c29 February 4, 2026 00:14

sean-mcmanus added 2 commits February 3, 2026 16:19

More fixes.

3b3a934

Update.

939d3c4

sean-mcmanus requested a review from Copilot February 4, 2026 00:42

Copilot started reviewing on behalf of sean-mcmanus February 4, 2026 00:43 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

Extension/.scripts/common.ts Show resolved Hide resolved

Extension/src/LanguageServer/client.ts Show resolved Hide resolved

Extension/src/LanguageServer/extension.ts Outdated Show resolved Hide resolved

Extension/eslint.config.js Show resolved Hide resolved

bobbrow reviewed Feb 4, 2026

View reviewed changes

Extension/src/LanguageServer/cppBuildTaskProvider.ts Outdated Show resolved Hide resolved

bobbrow previously approved these changes Feb 4, 2026

View reviewed changes

Code review updates.

0491f7e

sean-mcmanus dismissed bobbrow’s stale review via 0491f7e February 4, 2026 23:05

Colengms requested changes Feb 5, 2026

View reviewed changes

Extension/src/LanguageServer/clientCollection.ts Outdated Show resolved Hide resolved

Extension/src/LanguageServer/protocolFilter.ts Outdated Show resolved Hide resolved

Code review changes.

2bd255e

bobbrow approved these changes Feb 5, 2026

View reviewed changes

Colengms approved these changes Feb 5, 2026

View reviewed changes

sean-mcmanus merged commit 05d57e1 into main Feb 5, 2026
6 checks passed

sean-mcmanus deleted the seanmcm/updateEslint branch February 5, 2026 22:20

github-project-automation bot moved this from Pull Request to Done in cpptools Feb 5, 2026

Conversation

sean-mcmanus commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

sean-mcmanus commented Feb 3, 2026

Uh oh!

bobbrow commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bobbrow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sean-mcmanus commented Feb 2, 2026 •

edited

Loading