refactor(samples): replace pthreads with std::thread in multithreaded sample#13733
refactor(samples): replace pthreads with std::thread in multithreaded sample#13733Subham-KRLX wants to merge 7 commits intomicrosoft:mainfrom
Conversation
sean-mcmanus
left a comment
There was a problem hiding this comment.
Isn't it still using pthreads?
|
@sean-mcmanus All requested changes are now complete:
|
|
Hi @sean-mcmanus, Fully migrated from pthreads to std::thread Please let me know if anything else is needed! |
sean-mcmanus
left a comment
There was a problem hiding this comment.
Extension/.vscode/tasks.json shouldn't be modified and is unrelated to the Code Samples.
|
Reverted all changes to Extension/.vscode/tasks.json as requested. The PR now only includes the sample refactor. Ready for review! |
sean-mcmanus
left a comment
There was a problem hiding this comment.
You still have modifications to Extension/.vscode/tasks.json -- that file is intended to compile our TypeScript code in the Extension folder and is unrelated to the Code Samples.
|
@sean-mcmanus confirmation:
This PR now contains:
|
|
@sean-mcmanus To clarify:
|
|
Hi @sean-mcmanus, |
|
@Subham-KRLX We've been busy -- we'll try to review this next week. |
|
@Colengms I have made all the changes you suggested |
d5194b0 to
b111d6e
Compare
This PR addresses issue #13732 by refactoring the multithreaded sample to use C++11 instead of pthreads.
✅ Highlights: