fix(bindings): harden C# bindings and tests, add pooling, bump 0.9#571
Open
anakrish wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(bindings): harden C# bindings and tests, add pooling, bump 0.9#571anakrish wants to merge 1 commit intomicrosoft:mainfrom
anakrish wants to merge 1 commit intomicrosoft:mainfrom
Conversation
anakrish
force-pushed
the
csharp-memory-growth
branch
2 times, most recently
from
74248ef to
7e16cb9
Compare
anakrish
changed the title
anakrish
force-pushed
the
csharp-memory-growth
branch
from
7e16cb9 to
5cc3162
Compare
|
Confirmed at least in my basic tests, the changes here resolve the continual memory growth. Thanks for resolving this! |
anakrish
force-pushed
the
csharp-memory-growth
branch
2 times, most recently
from
ba3ad89 to
3fe0da6
Compare
Collaborator
Author
|
@billknye Thanks for trying it out and confirming the fix. I have pushed a version with more clean up and refactor. Mainly address scenario where a thread could dispose a C# wrapper (and hence potentially free the rust object) while another thread is using it. |
anakrish
force-pushed
the
csharp-memory-growth
branch
2 times, most recently
from
b1f65da to
a9a5e3d
Compare
- Introduce SafeHandleWrapper with gating, short drain wait, and deferred release on last in-flight exit. - Wire Engine/Program/Rvm/CompiledPolicy to wrapper (centralized handle use, interop helper). - Add C# memory growth tests (using/finalizer paths) and extend xtask C# runner options. - Add pooled marshalling utilities, ResultHelpers, and API cleanups; update versions/changelog. Fixes microsoft#570. Closes microsoft#554 Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
anakrish
force-pushed
the
csharp-memory-growth
branch
from
a9a5e3d to
9d2b1ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #570
closes #554