Open
Conversation
lalitb
approved these changes
Jan 16, 2024
Contributor
|
@ajadusum The android build is failing. Can you check if this is related to your changes ? |
ThomsonTan
previously approved these changes
Jan 16, 2024
Author
Yes, a test is failing. I will fix the mocks tomorrow. |
lalitb
requested changes
Apr 23, 2024
Contributor
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
The CI is breaking. Needs to be fixed before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: PowerInfoReceiver in HttpClient is processing broadcast on main thread. Android guideline is to avoid working on main thread on broadcast.
Fix: HttpClient already has a executor, processing the broadcast message async on the executor.