Cordova React TypeScript (from react ts sample @build2016) #100
Cordova React TypeScript (from react ts sample @build2016) #100ridomin wants to merge 7 commits intomicrosoft:masterfrom ridomin:master
Conversation
| @@ -0,0 +1,10 @@ | |||
| (function () { | |||
There was a problem hiding this comment.
why is not this a .ts file?
There was a problem hiding this comment.
I think this is boiler plate that gets included in every cordova project. Probably just easier not to touch it. Rido, do users ever edit these?
There was a problem hiding this comment.
No, it's a polyfill for old android versions. We can even remove it if you want.
however the windows one is important to allow dynamic scripts on Win8.1 (MSAppHost 2.0)
There was a problem hiding this comment.
i am assuming this is also part of the template, correct?
|
@ridomin thanks for the sample. we would love to host this on the new tutorial section on typescriptlang.org we are working on, do you thing you can give us a write up for getting this sample setup something along the lines of https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/tutorials/React%20%26%20Webpack.md? |
|
At the very least, a README covering how to build/launch the app in VS or VS Code would be helpful. |
cordova-react/package.json
Outdated
| "webpack": "" | ||
| }, | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1", |
There was a problem hiding this comment.
Should probably remove this if it doesn't do anything?
|
It feels like you should . Perhaps you could create a |
|
I tried to respect the same configuration and gitignore as https://github.com/Microsoft/typescript-build2016-demos/tree/master/react-reddit . Should I change it? |
| }; | ||
| $.ajax(settings).done(response => { | ||
| let submissions = (response as ApiResponse).data.children; | ||
| // TODO: filter on images |
There was a problem hiding this comment.
You're already filtering on the images.
5 participants
This sample shows how to use react and typescript in a cordova project
Works with Visual Studio Taco and VSCode