erase "support.variable.property.dom" scope#880
Open
sultan-ov wants to merge 1 commit intomicrosoft:masterfrom
Open
erase "support.variable.property.dom" scope#880sultan-ov wants to merge 1 commit intomicrosoft:masterfrom
sultan-ov wants to merge 1 commit intomicrosoft:masterfrom
Conversation
from: TypeScript.YAML-tmLanguage TypeScript.tmLanguage TypeScriptReact.tmLanguage microsoft#879 (comment)
|
|
Contributor
|
Tests failing aside, I mentioned in #879 about what sort of PRs we'd take for this and removing all of them isn't PR does do that. |
Author
|
The modified files are completely working, the integration tests need to be improved. |
sheetalkamat
force-pushed
the
master
branch
7 times, most recently
from
38ce771 to
0e1f58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from:
TypeScript.YAML-tmLanguage
TypeScript.tmLanguage
TypeScriptReact.tmLanguage
#879 (comment)