Abstract test snapshot builder into class#713
Open
dplain90 wants to merge 3 commits intomicrosoft:masterfrom
Open
Abstract test snapshot builder into class#713dplain90 wants to merge 3 commits intomicrosoft:masterfrom
dplain90 wants to merge 3 commits intomicrosoft:masterfrom
Conversation
|
|
sheetalkamat
requested changes
Mar 20, 2019
Member
sheetalkamat
left a comment
sheetalkamat
left a comment
There was a problem hiding this comment.
Please do not change file names and also do not convert to class, You can always use function instead.
sheetalkamat
force-pushed
the
master
branch
7 times, most recently
from
38ce771 to
0e1f58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a VSCode Programming Language Extension creator I want to test my tmLanguage file using the TypeScript-TmLanguage test suite to ensure my extension supports all future and current TS language use-cases.
This is not possible in it's current state as the snapshot build script has hardcoded file names and config settings.
This PR does the following:
Refactors
tests/build.tsinto a Builder classtests/builder.tswhich can be passed configuration optionsUses a Builder instance in
tests/test.tsto generate scopes